After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610894 - send FLUSH_STOP after FLUSH_START in videomixer
send FLUSH_STOP after FLUSH_START in videomixer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-24 01:11 UTC by Alessandro Decina
Modified: 2010-02-26 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (2.92 KB, patch)
2010-02-24 01:11 UTC, Alessandro Decina 		committed Details | Review

Description Alessandro Decina 2010-02-24 01:11:09 UTC 
Created attachment 154555 [details] [review]
proposed fix

during seeking, videomixer sends a FLUSH_START event downstream to unblock collectpads. It never sends FLUSH_STOP though, it relies on upstream elements to do that.

With gnonlin, it can happen that videomixer is unlinked (so no upstream) when a seek is issued, so a seek leaves videomixer:src and downstream elements flushing.
Comment 1 Sebastian Dröge (slomo) 2010-02-24 09:09:44 UTC 
Looks good IMHO, should we get this into the next pre-release?
Comment 2 Tim-Philipp Müller 2010-02-24 11:04:35 UTC 
commit 49b2a94644d6e26222418e71750500671b052658
Author: Alessandro Decina <alessandro.decina@collabora.co.uk>
Date:   Wed Feb 24 02:05:49 2010 +0100

    Make sure FLUSH_STOP is sent so not to leave downstream flushing.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-26 09:57:15 UTC 
Is this solved simmilar like in adder. Bother elements user collectpads in the same way and it would be good to keep the code somewhat aligned (so that it is easier to apply fixed vice versa).