After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610886 - Remove inset framing from the main window
Remove inset framing from the main window
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-23 22:07 UTC by Sander Dijkhuis
Modified: 2010-03-04 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshots with and without framing (106.52 KB, image/png)
2010-02-23 22:07 UTC, Sander Dijkhuis 		  Details
Remove inset frame from contact list in main window (889 bytes, patch)
2010-02-23 22:12 UTC, Sander Dijkhuis 		none Details | Review
Screenshot (16.45 KB, image/png)
2010-03-04 10:30 UTC, Michael Monreal 		  Details

Description Sander Dijkhuis 2010-02-23 22:07:31 UTC 
Created attachment 154547 [details]
Screenshots with and without framing

As mentioned by Hylke Bons in [1], unneeded framing should be avoided in GNOME windows. Empathy has got this around the contact list in the main window, and it looks better with the frame removed indeed.

[1] http://www.bomahy.nl/hylke/blog/on-gnome-and-elegance/
Comment 1 Sander Dijkhuis 2010-02-23 22:12:01 UTC 
Created attachment 154548 [details] [review]
Remove inset frame from contact list in main window
Comment 2 Guillaume Desmottes 2010-02-24 16:00:06 UTC 
Great; thanks a lot for this patch.

As we are already in UI freeze I sent a mail to the release team asking for an exception.
Comment 3 Guillaume Desmottes 2010-02-24 16:34:56 UTC 
Got the approval and merged to master. thanks!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Michael Monreal 2010-03-04 10:30:14 UTC 
Created attachment 155214 [details]
Screenshot

Note that this looks weird/wrong for themes that don't display toolbar separator lines. At least the clearlooks and murrine engines support this, so I think it is a common case.
Comment 5 Sander Dijkhuis 2010-03-04 10:41:32 UTC 
(In reply to comment #4)

In my screenshot with Clearlooks 2.29.x (id=154547), there was a toolbar border. Are you using an older version of Clearlooks? Note that this change will not be featured in GNOME <2.30 (afaik).