After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610872 - Change height of more apps view
Change height of more apps view
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 610879
Blocks:
 
 
Reported: 2010-02-23 18:59 UTC by Raphael Freudiger
Modified: 2010-03-18 00:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
new height for more apps view (110.96 KB, image/jpeg)
2010-02-23 18:59 UTC, Raphael Freudiger
  Details
[Overview] Make menu sizes relative to workspace area (3.83 KB, patch)
2010-03-10 16:13 UTC, Florian Müllner
committed Details | Review

Description Raphael Freudiger 2010-02-23 18:59:37 UTC
Created attachment 154537 [details]
new height for more apps view

The new more apps view looks a bit lost in the overview because it is relatively small. When scrolling sometimes only three rows are fully visible because of the shadow on top and bottom.

I would propose to stretch it to the full height of the workspaces. I did it with changing the gnome-shell.css and setting the height to 850px instead of 400px. Maybe this should be change to a relative height. Something like height = WORKSPACE_HEIGHT would be nice.
Comment 1 Jonathan Strander 2010-02-23 21:36:35 UTC
Funny, I think you and I had some similar thoughts, considering we posted within minutes of each other.

https://bugzilla.gnome.org/show_bug.cgi?id=610871

Yours is much less of a change though. I duplicated it by simply using a percentage (70%) as the height in gnome-shell.css. It still seems cramped, but more manageable.
Comment 2 Raphael Freudiger 2010-02-24 06:37:33 UTC
According to this bug https://bugzilla.gnome.org/show_bug.cgi?id=610879 percentage is not supported yet. It seems that adding a percentage as height has the same effect as commenting it out. But interestingly with no height mentioned in the css it is styled as I like to have it.
Comment 3 William Jon McCann 2010-02-24 11:11:37 UTC
Sounds like a worthwhile thing to try.  I agree that the height makes things feel cramped now.  We may also want to experiment with balancing the width somehow too.  But we need to be a bit more careful about that.  So, let's just try the height for now.
Comment 4 Jonathan Strander 2010-02-24 17:12:56 UTC
Re: Height
My solution (see the bug link I posted + mockup) was simply to reduce the number of applications per line. It makes height even more important, but means you can stick with about the same width.
Comment 5 Jonathan Strander 2010-02-24 17:13:48 UTC
(In reply to comment #4)
> Re: Height
Erm... Width, obviously.
Comment 6 drago01 2010-02-25 11:59:08 UTC
(In reply to comment #0)
> Created an attachment (id=154537) [details]
> new height for more apps view
> 
> The new more apps view looks a bit lost in the overview because it is
> relatively small. When scrolling sometimes only three rows are fully visible
> because of the shadow on top and bottom.
> 
> I would propose to stretch it to the full height of the workspaces. I did it
> with changing the gnome-shell.css and setting the height to 850px instead of
> 400px. Maybe this should be change to a relative height. Something like height
> = WORKSPACE_HEIGHT would be nice.

You can't just use 850px .. that is way to much it might look good on high res screens but on others it will end up being partly off screen.

We should wait for bug 610879 before doing that.
Comment 7 Florian Müllner 2010-03-10 16:13:10 UTC
Created attachment 155757 [details] [review]
[Overview] Make menu sizes relative to workspace area

This is an alternative approach which does not depend on bug 610879 - it just assigns a relative height in the code.
The percentage is fixed (at 90% of the workspaces area), but it would not be a problem to add a custom CSS property here - certainly a lot easier than making relative sizes work generally.
Comments?
Comment 8 drago01 2010-03-17 19:54:00 UTC
Review of attachment 155757 [details] [review]:

Yeah it makes sense to do it this way instead of hard coding 400px in the CSS, I would prefer a height of 100%,
but as you (and Jon) like the 90% (which isn't that much different) this isn't a blocker.

Code looks good.
Comment 9 Florian Müllner 2010-03-18 00:34:12 UTC
Attachment 155757 [details] pushed as 22bf4c8 - [Overview] Make menu sizes relative to workspace area