After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610866 - [playbin2] Don't fail if there are subtitles and audio but no video
[playbin2] Don't fail if there are subtitles and audio but no video
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 618052 618621 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-02-23 18:12 UTC by Sebastian Dröge (slomo)
Modified: 2010-05-19 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playsink: Don't fail if there are subtitles and audio but no video (7.58 KB, patch)
2010-02-23 18:13 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2010-02-23 18:12:39 UTC 
Attached patch makes playbin2 not error out if there are subtitles and audio but no video. If visualizations are enabled the subtitles are rendered on top of the visualization stream, otherwise the subtitles are not linked at all and only the audio is played (and a warning message is posted).

If there are only subtitles but neither audio nor video an error message is still posted.
Comment 1 Sebastian Dröge (slomo) 2010-02-23 18:13:37 UTC 
Created attachment 154532 [details] [review]
playsink: Don't fail if there are subtitles and audio but no video

Change playbin2 to not error out if there are subtitles and audio
but no video. If visualizations are enabled the subtitles are rendered on top
of the visualization stream, otherwise the subtitles are not linked at all and
only the audio is played (and a warning message is posted).

If there are only subtitles but neither audio nor video an error message is
still posted.

Fixes bug #610866.
Comment 2 Sebastian Dröge (slomo) 2010-05-14 12:48:14 UTC 
*** Bug 618621 has been marked as a duplicate of this bug. ***
Comment 3 Benjamin Otte (Company) 2010-05-14 13:21:57 UTC 
This doesn't seem fixed. I had this patch applied when I entered bug 618621 and made sure it still happens - at least with the file in that bug, the one from http://mobilemacs.de/2010/02/mm042-bi-ba-buzzemann.html
Comment 4 Sebastian Dröge (slomo) 2010-05-14 15:19:20 UTC 
commit 0c85f2c890ddf1968520c030195e735199622615
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri May 14 17:17:33 2010 +0200

    playsink: Don't fail if subtitles are used but only audio is available and no visualiza
    
    Instead simply disable displaying of the subtitles for now, as was
    intended by that part of code...
    
    Fixes bug #610866.
Comment 5 Tim-Philipp Müller 2010-05-19 14:49:43 UTC 
*** Bug 618052 has been marked as a duplicate of this bug. ***