GNOME Bugzilla – Bug 610836
Support for application-indicators
Last modified: 2010-12-31 03:00:06 UTC
Created attachment 154508 [details] [review] Patch which implements GkbdConfiguration which is used to support application indicators We would like to support application-indicators for gnome-power-manager as proposed at this page: https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators To support application-indicators with the keyboard plugin in gnome-settings-dameon, some support in libgnomekbd would be required. I did not want to copy the code from gkbd-indicator.[ch] and gkbd-status.[ch] again to create an application-indicator depended class but created a more general gkbd-configuration.[ch] class, which can than be used in gnome-settings-dameon to create the application-indicator. One could basically refactor gkbd-indicator.c and gkbd-status.c to be based on gkbd-configuration.[ch] (instead of the globals global variable in both implementations). I could provide a patch for that also.
Jan, could you please give a bit of background? Is AI approach formally blessed by GNOME over status icons? I did not get that impression (probably I overlooked something) I do not actually insist on keeping the status icon version at all (if gnome goes AI way). The only place it is used is g-s-d anyway. What I am looking for is: - Something that would be compatible with gnome-3.0 - As little copypasted code as possible (it that aspect I would be very interested in your idea to base gkbd-indicator on gkbd-configuration). Thanks!
I think this new GObject should have some documentation. At the moment there are no comments that say what it is or what it's for.
Jan Arne, can you address the issues addressed in comment #1 and comment #2? Sergey, is patch 154508 rejected for now?
Yes, for a moment I do not see the need for the patch 154508.
I committed GkbdConfiguration, refactored indicator and status icon. Please check.