GNOME Bugzilla – Bug 610765
Null checking on parameters should use g_arg_info_may_be_null
Last modified: 2021-05-25 17:32:21 UTC
Created attachment 154469 [details] [review] null check args attached in patch - will commit once I get back to the machine with ssh access.
This causes a few issues with broken gir data.. eg. Gst.Bus.prototype.add_watch has last argument user_data - which should really be marked as allow-none="1" a workaround is to send false, to it, I think it's still the correct behaviour though, as per the bug report on gobject-introspection which they basically say binding must check for this. <method name="add_watch" c:identifier="gst_bus_add_watch" doc="Adds a bus watch to the default main context with the default priority. This function is used to receive asynchronous messages in the main loop. There can only be a single bus watch per bus, you must remove it before you can set a new one. The watch can be removed using g_source_remove() or by returning FALSE from @func. MT safe."> <return-value transfer-ownership="none"> <type name="uint" c:type="guint"/> </return-value> <parameters> <parameter name="func" transfer-ownership="none" closure="2"> <type name="BusFunc" c:type="GstBusFunc"/> </parameter> <parameter name="user_data" transfer-ownership="none"> <type name="any" c:type="gpointer"/> </parameter> </parameters> </method>
Adding upstream fixes as blockers Commited Fix to git.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/seed/-/issues/ Thank you for your understanding and your help.