Created attachment 154446 [details] [review]
[ShellGenericContainer] Add method to get number of skipped children

This will be used in search results.

Created attachment 154447 [details] [review]
Use AppWellIcon for search results

Switch to using an application icon as per design.

We need to drop the 4 pixels padding to ensure we fit 3 icons.

There was a typo where getVisibleCount should have been getVisibleResultsCount.

Review of attachment 154447 [details] [review]:

Trying it out, it should left-justify not center when there are less results than columns.

I'm wondering if two rows would make more sense than one - right now, if you type just a few characters you definitely get the sense of "only 4 results?". We'll see. (Certainly not worth implementing two rows certainly without design feedback)

Looks fine to commit in review other than minor fixes.

::: data/theme/gnome-shell.css
@@ +431,3 @@
 }
 
+.app-well-app.selected {

Hmm, this is sort of ugly - we use pseudo-classes for :selected in some other places, but not here (presumbaly because we have hover on this and that would override and erase the :selected pseudo-class). Wonder if we should make it add and remove 'hover' from the style pseudo-class rather than overriding the style pseudo-class completely. (The pseudo-class, like the class can be a list of classes) Well, this is OK for now.

@@ +432,3 @@
 
+.app-well-app.selected {
+    border: 1px solid #666666;

Selection indication for other search results is the border + a lighter background - I'm pretty sure we need that here as well - indication for keyboard focus has to be strong than for hover since the user isn't already looking right there.

::: js/ui/appDisplay.js
@@ +195,3 @@
+            childBox.x2 = childBox.x1 + natWidth;
+            childBox.y1 = Math.floor(yPadding / 2);
+            childBox.y2 = availHeight - childBox.y1;

This is an off-by-one, if yPadding is odd. You want:

 availHeight - (yPadding - childBox.y1);

@@ +234,3 @@
+    selectIndex: function (index) {
+        let nVisible = this.getVisibleResultCount();
+        log("nVisible=" + nVisible);

Leftover log

@@ +246,3 @@
+            return false;
+        let targetActor = children[index];
+        log("setting selected = true");

leftover log

Review of attachment 154446 [details] [review]:

This looked fine

(In reply to comment #3)
> 
> Selection indication for other search results is the border + a lighter
> background - I'm pretty sure we need that here as well - indication for
> keyboard focus has to be strong than for hover since the user isn't already
> looking right there.

I'm not quite sure how to handle this though if the app is running; should we use a lighter gradient?

Attachment 154446 [details] pushed as c635cb7 - [ShellGenericContainer] Add method to get number of skipped children
Attachment 154447 [details] pushed as 83f1187 - Use AppWellIcon for search results