GNOME Bugzilla – Bug 610455
Removed account aren't show in log viewer
Last modified: 2018-05-22 14:02:38 UTC
This bug applies both to current git version (2.29.x) and the future TPL enabled version. Empathy queries the account manager only for the valid accounts, and shows the result in the log viewer for account selection. If one removes an account which has a log history, this account should be shown in the log viewer and empathy should allow the user to search the removed account's logs.
A note about TPL version: there is a FIXME in libempathy/empathy-message.c pointing to this bug, which alerts that the way the account is obtained might be a problem when this bug will be fixed. empathy_contact_from_tpl_contact() needs a TpAccount only because it's the only way for EmpathyContact to obtain the avatar instance. A suggestion might be keeping a map of avatar_token->avatar_file_path in order to look up the token instead of building it's path using a TpAcccount. Removing the needing of a TpAccount for the avatar, will make useless for empathy_contact_from_tpl_contact() to have TpAccount as arg, and thus for empathy_message_from_tpl_log_entry() to create the account. This also would let the log window browse removed accounts with probably just small changes in EmpathyAccountChooser to allow it to query TPL for all the logged accounts, when in a log window.
Created attachment 157509 [details] [review] Patch to show a Display Name for TpAccount, when not present
Created attachment 157513 [details] show last segment of account path
A memo: The 1st patxh is a (really) poor approach to add a Display name when TPL returns a TpAccount in a TplLogSearchHit which is actually not existent anymore (ie removed). The 2nd one is the same but using the last segment of the account path (ie "user_40jabber_2eorg0") Not patched, the log-window would show an empty string for the Account Name column.
This is blocked by https://bugs.freedesktop.org/show_bug.cgi?id=26648
Comment on attachment 157509 [details] [review] Patch to show a Display Name for TpAccount, when not present [Setting "patch" flag so this can actually be queried for.]
Cosimo: I'm really sorry, I missed those patches. As André said, tagging them as 'patch' make them easier to be found. Anway, I think the right approach for this is to use the new "account identifier" approach we discussed few weeks ago. Do you agree?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/188.