After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610337 - pulsesink: gst_pulsesink_get_mute: set result earlier.
pulsesink: gst_pulsesink_get_mute: set result earlier.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal blocker
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-18 08:14 UTC by Philippe Normand
Modified: 2010-02-22 19:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.09 KB, patch)
2010-02-18 08:16 UTC, Philippe Normand 		committed Details | Review

Description Philippe Normand 2010-02-18 08:14:16 UTC 
If no buffer hasn't yet been process by the sink get_mte() will always
return FALSE, whatever the psink->mute value is.
Comment 1 Philippe Normand 2010-02-18 08:16:35 UTC 
Created attachment 154108 [details] [review]
proposed patch
Comment 2 Philippe Normand 2010-02-18 08:17:19 UTC 
Setting to blocker as requested by slomo
Comment 3 Sebastian Dröge (slomo) 2010-02-22 07:21:59 UTC 
Comment on attachment 154108 [details] [review]
proposed patch

Yes, we should definitely get this into this release.
Comment 4 Sebastian Dröge (slomo) 2010-02-22 19:49:42 UTC 
commit 3ab666762fa6da97f66c8398d2ac6ec697da5708
Author: Philippe Normand <phil@base-art.net>
Date:   Thu Feb 18 09:05:50 2010 +0100

    pulsesink: gst_pulsesink_get_mute: set result earlier.
    
    In the cases where no buffer was process yet or the index is not
    available, get_pulsesink_get_mute() would unconditionally return
    FALSE.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=610337