Created attachment 154100 [details] [review]
get_app_for_window_direct search ShellApp by window, before create.

I can't reproduce this by moving Nautilus; can anyone else?

Review of attachment 154100 [details] [review]:

Oh; on second thought, I see how this could occur, your Nautilus window is probably not app-tracked.

::: src/shell-app-system.c
@@ +486,3 @@
 }
+shell_app_system_lookup_by_window (ShellAppSystem *self, MetaWindow *window)
+ShellApp *

This needs to conform to the coding style:

* Needs a documentation header
* needs (transfer full) on the return value
* Separate indented lines for parameters

I'd prefer this function be called "shell_app_system_get_app_for_window" since it's similar to shell_app_system_get_app.  If the app isn't found, then you call _shell_app_new_for_window.

::: src/shell-window-tracker.c
@@ +310,3 @@
+      if (app == NULL)
+      app = shell_app_system_lookup_by_window (appsys, window);
+    {

Then this code just becomes: return shell_app_system_get_app_for_window (appsys, window);

Created attachment 154250 [details] [review]
get_app_for_window_direct search ShellApp by window, before create.

Review of attachment 154250 [details] [review]:

Looks good, thank you!

Review of attachment 154250 [details] [review]:

Actually one comment.

::: src/shell-app-system.c
@@ +495,3 @@
+ * @self: A #ShellAppSystem
+ * shell_app_system_get_app_for_window:
+/**

Oh actually I missed this part, this needs to be:

ShellApp *
shell_app_system_get_app_for_window (ShellAppSystem *self,
                                     MetaWindow     *window)