GNOME Bugzilla – Bug 610296
[qtdemux] Confusion with gst/qt segments
Last modified: 2010-02-18 11:12:47 UTC
Due to qtdemux having to handle gst and edts segments, a mistake was introduced in 8ca984d5 The problem is that (on segment activation) the edts entry duration is used instead of the total gst segment duration. Patches follow.
Created attachment 154067 [details] [review] qtdemux: Use the correct duration when comparing segments Do not confuse QtDemuxSegments with GstSegments when comparing the total file duration with the segment duration Fixes #610296
Should the debug (warning) message not be adjusted as well ? I am not sure whether comparing a QtDemuxSegment.time to a GstSegment.stop works ok, since they are on a different timeline (global time versus media/track time). IIRC, I originally intended to compare the total file duration (in a GstSegment.duration) to a QtDemuxSegment.time (which are both in the same global timeline).
Created attachment 154083 [details] [review] qtdemux: Use the correct duration when comparing segments Updated patch with Mark's comments
What is the reason for qtdemux->segment.stop != -1 in there (or perhaps still a leftover from a previous version, might have to be qtdemux->segment.duration) ?
Created attachment 154120 [details] [review] qtdemux: Use the correct duration when comparing segments Yes, that was a left over, this version has it fixed.
OK [FWIW] :)
Module: gst-plugins-good Branch: master Commit: f1c61e1d84ee83336bfb59aa9ec8a49afbd92539 URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=f1c61e1d84ee83336bfb59aa9ec8a49afbd92539 Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk> Date: Wed Feb 17 16:27:33 2010 -0300 qtdemux: Use the correct duration when comparing segments Do not confuse QtDemuxSegments with GstSegments when comparing the total file duration with the segment duration Fixes #610296