After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610280 - [qtdemux] issue with corrupted 3gp file
[qtdemux] issue with corrupted 3gp file
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.18
Other Linux
: Normal blocker
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-17 17:05 UTC by Robert Swain
Modified: 2010-02-17 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make stts_time and stts_duration guint32 as they should be (1.18 KB, patch)
2010-02-17 17:08 UTC, Robert Swain 		accepted-commit_now Details | Review

Description Robert Swain 2010-02-17 17:05:16 UTC 
+++ This bug was initially created as a clone of Bug #595942 +++

It seems during the course of my editing of the sample data parsing code, I got confused and changed some guint32 to guint64 which causes problems for some files with weird sample durations. The data read from the bit stream is uint32 and so the variable should be too. Patch incoming.
Comment 1 Robert Swain 2010-02-17 17:08:41 UTC 
Created attachment 154056 [details] [review]
Make stts_time and stts_duration guint32 as they should be
Comment 2 Robert Swain 2010-02-17 17:33:51 UTC 
Commit: 2723de585eb82f9bcf9230ab9c71958426bc45f8
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=2723de585eb82f9bcf9230ab9c71958426bc45f8

Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Wed Feb 17 18:06:29 2010 +0100

qtdemux: add durations modulo 1<<32

For calculating the durations of each sample, we are supposed to add each
duration modulo 1<<32 so make the elapsed time counter a uint32.

Fixes #610280