GNOME Bugzilla – Bug 610268
[rtsp] NULL pointer reference in gstrtspconnection
Last modified: 2010-02-18 18:13:01 UTC
Calling gst_rtsp_connection_send before gst_rtsp_connection_set_auth has been called leads to a NULL pointer reference in auth_digest_compute_hex_urp since both username and password will then be NULL. This only happens sometimes, so I guess that there must be some special case in rtspsrc that leads to this call chain. Note that both user name and password has been specified and are available in the uri, this is thus not a configuration problem.
Created attachment 154041 [details] [review] Check username/password before usage. This is just to make sure the rtspconnection lib does not crash. The rtspsrc should probably be fixed as well.
Guess we should check for NULL in the BASIC case as well: commit a8f51d61f7e55d48b38b481ec0d50206b06e896e Author: Patrick Radizi <patrick.radizi@axis.com> Date: Thu Feb 18 12:42:53 2010 +0000 rtspconnection: make sure not to dereference NULL username or password Fixes #610268. > This is just to make sure the rtspconnection lib does not crash. The rtspsrc > should probably be fixed as well. Could you file a bug please? (With patch if possible)
Comment on attachment 154041 [details] [review] Check username/password before usage. PS: would be great if you could attach patches in 'git format-patch -1' format next time (so I don't have to type author name and commit message).