After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610256 - Use G_VALUE_COLLECT_INIT if available
Use G_VALUE_COLLECT_INIT if available
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-17 12:20 UTC by Edward Hervey
Modified: 2010-03-12 09:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst: Use G_VALUE_COLLECT_INIT if available (3.49 KB, patch)
2010-02-17 12:21 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2010-02-17 12:20:42 UTC 
Since glib 2.23.2, a faster variant of G_VALUE_COLLECT is available.

The following patche makes use of it if it's present.
Comment 1 Edward Hervey 2010-02-17 12:21:28 UTC 
Created attachment 154024 [details] [review]
gst: Use G_VALUE_COLLECT_INIT if available

This brings total call speedups between 5% and 25%.
gst_caps_set_simple_valist: +5%
gst_structure_set_valist: + 10%
gst_structure_id_set_valist: +25%
gst_tag_list_add_valist: +5%

Measured using valgrind when run over the discovery of 200 media files.
Comment 2 Sebastian Dröge (slomo) 2010-02-17 16:34:28 UTC 
Looks good IMHO, should probably be included in this release because it gives performance improvements for free ;)
Comment 3 Edward Hervey 2010-03-12 09:02:23 UTC 
commit bbe26d36ba42ec414a4d31a8864b23cf00906764
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Wed Feb 17 13:02:43 2010 +0100

    gst: Use G_VALUE_COLLECT_INIT if available
    
    This brings total call speedups between 5% and 25%.
    gst_caps_set_simple_valist: +5%
    gst_structure_set_valist: + 10%
    gst_structure_id_set_valist: +25%
    gst_tag_list_add_valist: +5%
    
    Measured using valgrind when run over the discovery of 200 media files.
    
    Fixes #610256