After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610248 - don't poll geometry for every frame
don't poll geometry for every frame
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal enhancement
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-17 11:35 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2010-03-18 19:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
update geometry in event thread (if possible) (2.75 KB, patch)
2010-02-17 11:35 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		none Details | Review
update geometry in event thread (if possible) (3.09 KB, patch)
2010-02-19 14:37 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-17 11:35:10 UTC 
xvimagesink and ximagesink poll the geometry for every frame. It would be nice to avoid this for performance reason (long playback time on battery powered devices).
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-17 11:35:53 UTC 
Created attachment 154020 [details] [review]
update geometry in event thread (if possible)
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-17 13:02:53 UTC 
If the patches in bug #610249 look good, we can remove the polling in all cases.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-19 14:37:29 UTC 
Created attachment 154212 [details] [review]
update geometry in event thread (if possible)

This also updated the geometry in _expose() and thus gets rid of the polling totaly. This patch is now independent of bug #610249.
Comment 4 Edward Hervey 2010-03-18 17:08:22 UTC 
You sure you committed the patch ?
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2010-03-18 19:11:20 UTC 
Yes, I am.

commit 7b13aeee329834a29642360f958f27a6ef23bcf7
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Tue Feb 16 12:06:08 2010 +0200

    x(v)imagesink: take new size from event thread and do not poll for every frame
    
    We can update the geometry in ConfigureNotify (unless we disable event-
    handling). If event handling is disabled, one should use _expose() to trigger a
    redraw and update the geometry.