After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610244 - Fix linking with pedantic linkers
Fix linking with pedantic linkers
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-17 11:11 UTC by Bastien Nocera
Modified: 2010-03-10 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix linking with pedantic linkers (1.22 KB, patch)
2010-02-17 11:11 UTC, Bastien Nocera
none Details | Review
Fix linking with pedantic linkers (3.41 KB, patch)
2010-03-09 11:30 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2010-02-17 11:11:45 UTC
Probably not the best solution, but works nonetheless.
Comment 1 Bastien Nocera 2010-02-17 11:11:47 UTC
Created attachment 154014 [details] [review]
Fix linking with pedantic linkers

The common library and the background plugin both use libX11
symbols so need to link against it.
Comment 2 Jens Granseuer 2010-02-20 09:49:55 UTC
Uh, shouldn't this be done in configure instead? Adding explicit lib dependencies in the Makefiles just doesn't seem right.
Comment 3 Bastien Nocera 2010-03-09 11:30:36 UTC
Created attachment 155631 [details] [review]
Fix linking with pedantic linkers

The common library and the background and mouse plugins use libX11
symbols so need to link against it. The media-keys, and mouse
plugins use libm symbols so need to link against it.
Comment 4 Bastien Nocera 2010-03-10 10:20:00 UTC
Attachment 155631 [details] pushed as 393ca4f - Fix linking with pedantic linkers