After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610205 - [gir-repository] build: Fix test when building without GTK+
[gir-repository] build: Fix test when building without GTK+
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-02-16 22:42 UTC by Damien Lespiau
Modified: 2015-02-07 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch against current master of gir-repository (794 bytes, patch)
2010-02-16 22:42 UTC, Damien Lespiau 		accepted-commit_now Details | Review
build: Fix test when building without GTK+ (843 bytes, patch)
2010-05-20 16:57 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Damien Lespiau 2010-02-16 22:42:27 UTC 
Created attachment 153975 [details] [review]
patch against current master of gir-repository

GIR_CHECK() defines have_$1 where $1 is the first argument given to
the macro. The check should use $have_Gtk then.
Comment 1 Johan (not receiving bugmail) Dahlin 2010-04-07 16:36:06 UTC 
Review of attachment 153975 [details] [review]:

Looks good, please commit
Comment 2 Damien Lespiau 2010-04-07 17:34:32 UTC 
Hi,

I still don't have a GNOME account, I don't think I've done any meaningful patches to ask for a git account (where you need a module owner to sponsor you basically). So, can you please push it for me?

thanks,
Comment 3 Johan (not receiving bugmail) Dahlin 2010-05-20 16:57:13 UTC 
The following fix has been pushed:
32633b7 build: Fix test when building without GTK+
Comment 4 Johan (not receiving bugmail) Dahlin 2010-05-20 16:57:17 UTC 
Created attachment 161568 [details] [review]
build: Fix test when building without GTK+

GIR_CHECK() defines have_$1 where $1 is the first argument given to
the macro. The check should use $have_Gtk then.
Comment 5 André Klapper 2015-02-07 17:03:41 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]