After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610194 - no way to rename notebooks
no way to rename notebooks
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
0.7.x
Other Linux
: Normal normal
: ---
Assigned To: Aurimas Černius
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-16 20:57 UTC by Mark Edgington
Modified: 2010-12-30 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Ported Tomboy notebook rename feature. (3.59 KB, patch)
2010-05-14 21:59 UTC, Aurimas Černius
none Details | Review
Ported Tomboy notebook rename feature. (3.58 KB, patch)
2010-05-17 20:52 UTC, Aurimas Černius
none Details | Review
Ported Tomboy notebook rename feature. (3.60 KB, patch)
2010-07-10 22:50 UTC, Aurimas Černius
none Details | Review
Ported Tomboy notebook rename feature. (3.56 KB, patch)
2010-07-30 19:49 UTC, Aurimas Černius
none Details | Review
Ported Tomboy notebook rename feature with enhancement. (3.65 KB, patch)
2010-09-16 20:21 UTC, Aurimas Černius
none Details | Review

Description Mark Edgington 2010-02-16 20:57:53 UTC
There seems to be no way to rename notebooks that I could find.
Comment 1 Aurimas Černius 2010-05-14 21:59:22 UTC
Created attachment 161097 [details] [review]
Ported Tomboy notebook rename feature.

It seems, that additional modification for Tag is needed, to store Note::Ptr instead of Note*. Right now an additional search for note by uri needs to be done.
But it seems to work for me.
Comment 2 Hubert Figuiere (:hub) 2010-05-16 19:26:17 UTC
Don't change the kind of pointer. 
A Note* is used to avoid circular references and work around circular definition, if I remember. There was a very serious reason back when I wrote this.

You can call Note::shared_from_this() to get the Note::Ptr associated with it as Note inherit from "boost::enable_shared_from_this()"
Comment 3 Aurimas Černius 2010-05-17 20:52:49 UTC
Created attachment 161270 [details] [review]
Ported Tomboy notebook rename feature.

Updated patch according to Hubert's suggestions.
Comment 4 Aurimas Černius 2010-07-10 22:50:59 UTC
Created attachment 165652 [details] [review]
Ported Tomboy notebook rename feature.

Fixed some whitespace issues in previous patch.
Comment 5 Aurimas Černius 2010-07-30 19:49:09 UTC
Created attachment 166853 [details] [review]
Ported Tomboy notebook rename feature.

Removed "TODO" comment near the end, this issue fixed in bug 625679.
Comment 6 Aurimas Černius 2010-09-16 20:21:30 UTC
Created attachment 170439 [details] [review]
Ported Tomboy notebook rename feature with enhancement.

Improved patch. Do not lose notebook template note.
Requires Bug 629876 to be committed.
Comment 7 Aurimas Černius 2010-12-16 21:31:04 UTC
Comment on attachment 166853 [details] [review]
Ported Tomboy notebook rename feature.

I put this back from obsolete, as fix in Bug 627539 makes it right again.
Comment 8 Aurimas Černius 2010-12-30 20:46:42 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.