After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610039 - [main.js] Don't handle panel-run-dialog twice
[main.js] Don't handle panel-run-dialog twice
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-15 21:06 UTC by drago01
Modified: 2010-02-16 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[main.js] Don't handle panel-run-dialog twice (977 bytes, patch)
2010-02-15 21:06 UTC, drago01 		none Details | Review
Remove panel-run-dialog handling from shell-global (2.31 KB, patch)
2010-02-15 21:20 UTC, drago01 		committed Details | Review

Description drago01 2010-02-15 21:06:18 UTC 
Currently we have two handlers for panel-run-dialog that both do pretty much the same.

I don't see a reason why we need both (removing one does not fix or break anything but it looks odd to me).
Comment 1 drago01 2010-02-15 21:06:49 UTC 
Created attachment 153865 [details] [review]
[main.js] Don't handle panel-run-dialog twice
Comment 2 drago01 2010-02-15 21:20:50 UTC 
Created attachment 153867 [details] [review]
Remove panel-run-dialog handling from shell-global

Remove it from shell-global too.
Comment 3 Dan Winship 2010-02-15 22:20:43 UTC 
Comment on attachment 153867 [details] [review]
Remove panel-run-dialog handling from shell-global

looks good, but you can get rid of the panel-main-menu signal too while you're at it (in both main.js and shell-global.c)
Comment 4 drago01 2010-02-16 15:51:51 UTC 
Comment on attachment 153867 [details] [review]
Remove panel-run-dialog handling from shell-global

Pushed as 4749393 with additions from Comment 3.