After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610032 - Do not show "respond" in "contact has gone offline" notification
Do not show "respond" in "contact has gone offline" notification
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Notifications
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-15 19:49 UTC by freggy1
Modified: 2010-02-17 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/notifications (1.02 KB, patch)
2010-02-17 10:14 UTC, Guillaume Desmottes 		accepted-commit_now Details | Review

Description freggy1 2010-02-15 19:49:04 UTC 
When a contact goes offline, the notification which is shown contains a "Respond" button. This does not make much sense if the contact has gone offline, so it should not be shown in that case.
Comment 1 Guillaume Desmottes 2010-02-16 13:35:04 UTC 
Closing as a dup of bug #597124 as that's the same issue.

*** This bug has been marked as a duplicate of bug 597124 ***
Comment 2 Guillaume Desmottes 2010-02-17 10:14:07 UTC 
Actually we could easily fix this issue.
Comment 3 Guillaume Desmottes 2010-02-17 10:14:59 UTC 
Created attachment 154011 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/notifications

 src/empathy-event-manager.h |    1 -
 src/empathy-status-icon.c   |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 4 Cosimo Cecchi 2010-02-17 11:21:44 UTC 
Review of attachment 154011 [details] [review]:

Looks good to me.
Comment 5 Guillaume Desmottes 2010-02-17 11:38:22 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.