Created attachment 153915 [details] [review]
Adjust behavior of search results to match app well

Currently, activating a search result always opens a new window. Change
this behavior, so that if an application has open windows, the most
recently used one is activated instead.

Also change the implementation of dnd of search results to allow providers
to treat results activated via dnd differently.

Review of attachment 153915 [details] [review]:

::: js/ui/dash.js
@@ +392,3 @@
 
+            this.provider.shellWorkspaceLaunch(this.metaInfo.id);
+        try {

Hm, what about an optional argument for activateResult?  Or a new function activateResultFull?

It seems cleaner to me to either say:

if (this.provider.activateResultFull) {
  this.provider.activateResultFull(id, true);
} else {
 ...
}

or:

if (this.provider.canDragActivate()) {
  this.provider.dragActivate(id);
} else {
}

Created attachment 153943 [details] [review]
Adjust behavior of search results to match app well

(In reply to comment #2)
Oh, I wasn't aware that method existance can be tested with a simple if. That's
obviously much better than my exception hack ...


> Hm, what about an optional argument for activateResult?  Or a new function
> activateResultFull?

I don't know if I like that idea - in my opinion, optional arguments should
only be optional for the caller, but not for the callee.

Another function activateResultFull() would do though ...

 
> It seems cleaner to me to either say:
> 
> if (this.provider.activateResultFull) {
>   this.provider.activateResultFull(id, true);
> }
> 
> or:
> 
> if (this.provider.canDragActivate()) {
>   this.provider.dragActivate(id);
> }

Both look good to me - for the updated patch I used the latter (as dragActivateResult), but without the additional method for the check.

Review of attachment 153943 [details] [review]:

Looks great, thanks!

Attachment 153943 [details] pushed as 97e19d7 - Adjust behavior of search results to match app well