After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609932 - Add bindings for rsvg_handle_get_dimensions{_sub,}
Add bindings for rsvg_handle_get_dimensions{_sub,}
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gnome2::Rsvg
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-02-14 18:42 UTC by Neil Roberts
Modified: 2010-05-17 22:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add bindings for rsvg_handle_get_dimensions{_sub,} (2.78 KB, patch)
2010-02-14 18:42 UTC, Neil Roberts 		needs-work Details | Review

Description Neil Roberts 2010-02-14 18:42:10 UTC 
Here's a patch to add bindings for rsvg_handle_get_dimensions and rsvg_handle_get_dimensions_sub. I don't know the Perl guts that well so I'm not 100% sure if this is correct but I based it on the bindings for cairo_font_extents so it should be vaguely right.

It's quite hard to use Cairo backend without these functions so it would be good to have them.
Comment 1 Neil Roberts 2010-02-14 18:42:40 UTC 
Created attachment 153775 [details] [review]
Add bindings for rsvg_handle_get_dimensions{_sub,}

This adds bindings for rsvg_handle_get_dimensions and
rsvg_handle_get_dimensions_sub. They both use a new type called
RsvgDimensionData which is added to the typemap.
Comment 2 Torsten Schoenfeld 2010-03-02 22:16:28 UTC 
Review of attachment 153775 [details] [review]:

Thanks for the patch (in git form even!).  Just two things that need fixing before it can go in:

* Since typemaps are public, and the new typemap uses a new converter, we need to properly export this converter via rsvg2perl.h.

* The new methods need tests.
Comment 3 Torsten Schoenfeld 2010-05-17 22:15:42 UTC 
These methods (and a couple more) are now wrapped in the just-released 0.11.  Unfortunately, I forgot about your patch and ended up writing nearly the exact same code. :-/  Anyway, thanks for the patch!