After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609929 - Dragging between two windows cause the menu widget to be destroyed
Dragging between two windows cause the menu widget to be destroyed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
2.19.x
Other Linux
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
: 611039 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-02-14 17:49 UTC by Sjoerd Simons
Modified: 2010-03-22 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
example case, dragging the tabs between the two windows causes the menu item to disappear (1.15 KB, text/plain)
2010-02-14 17:49 UTC, Sjoerd Simons 		  Details
Prevent destruction of the menu item (1.19 KB, patch)
2010-02-14 19:47 UTC, Sjoerd Simons 		none Details | Review

Description Sjoerd Simons 2010-02-14 17:49:10 UTC 
Created attachment 153773 [details]
example case, dragging the tabs between the two windows causes the menu item to disappear

When using a GtkNotebook with a popup menu with widgets that aren't just GtkLabels, the menu items disappear when dragging between two notebook.

Attached is a simple example program showing this. To reproduce just drag a tab from one window to another, it's item in the right-click menu then because an empty placeholder instead of the actual menu item that was put in place.

This seem to be caused by the fact that when the MenuItem for the page gets removed when the tab is detached it call gtk_widget_destroy on all its child widgets, including the widget we put in the menu. When this widget is later (re)added to the menu it doesn't show up anymore.
Comment 1 Sjoerd Simons 2010-02-14 19:47:49 UTC 
Created attachment 153792 [details] [review]
Prevent destruction of the menu item
Comment 2 Guillaume Desmottes 2010-02-26 11:55:51 UTC 
*** Bug 611039 has been marked as a duplicate of this bug. ***
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2010-03-13 02:22:17 UTC 
Given hard code freeze is on monday, maybe it makes sense to check this ;).

Any reason why you haven't pushed this furhter Sjoerd?
Comment 4 Guillaume Desmottes 2010-03-13 08:52:30 UTC 
The reason is that this patch has not been reviewed by a GTK+ guy.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2010-03-13 15:58:04 UTC 
Oh I mean further as in getting a review. Well let's bug people in #gtk I guess. It's an ugly crasher for empathy.
Comment 6 Matthias Clasen 2010-03-22 18:15:50 UTC 
Seems to be correct, committed.