After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609843 - Crashed when I closed one tab and hence switched to another tab for a disconnected account
Crashed when I closed one tab and hence switched to another tab for a disconn...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
unspecified
Other Linux
: Normal major
: ---
Assigned To: empathy-maint
: 609769 609984 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-02-13 16:16 UTC by Will Thompson
Modified: 2010-02-15 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't crash when switching to a tab with no TpChat (1.01 KB, patch)
2010-02-13 16:17 UTC, Will Thompson 		none Details | Review

Description Will Thompson 2010-02-13 16:16:24 UTC 



+
Trace
    220557






    

  • 
#0
empathy_tp_chat_acknowledge_messages

    
                at ../../libempathy/empathy-tp-chat.c
                  line
                  1676

    

    • 

  • 
#1
empathy_chat_messages_read

    
                at ../../libempathy-gtk/empathy-chat.c
                  line
                  2950

    

    • 

  • 
#2
chat_window_page_switched_cb

    
                at ../../src/empathy-chat-window.c
                  line
                  1409

    

    • 








Since it is perfectly kosher for there to be no EmpathyTpChat associated with an EmpathyChat (see chat_destroy_cb()) I propose to just not call empathy_tp_chat_acknowledge_messages() if priv->tp_chat is NULL. Patch to follow.

A quick skim through EmpathyChat suggests that we'll also crash if the user list is made visible on a disconnected chat room.






Comment 1


Will Thompson





          2010-02-13 16:17:11 UTC
        



Created attachment 153719 [details] [review]
Don't crash when switching to a tab with no TpChat

Fixes: #609843






Comment 2


Guillaume Desmottes





          2010-02-13 16:59:26 UTC
        



*** Bug 609769 has been marked as a duplicate of this bug. ***






Comment 3


Guillaume Desmottes





          2010-02-13 17:00:24 UTC
        



Great; merged. Thanks a lot!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.






Comment 4


Guillaume Desmottes





          2010-02-15 11:50:05 UTC
        



*** Bug 609984 has been marked as a duplicate of this bug. ***