After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609810 - Replace GNOME_MAINTAINER_MODE_DEFINES with GNOME_DISABLE_DEPRECATED
Replace GNOME_MAINTAINER_MODE_DEFINES with GNOME_DISABLE_DEPRECATED
Status: RESOLVED DUPLICATE of bug 614360
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-02-13 05:12 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-05-30 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace GNOME_MAINTAINER_MODE_DEFINES with GNOME_DISABLE_DEPRECATED (1.65 KB, patch)
2010-02-13 05:13 UTC, Javier Jardón (IRC: jjardon) 		needs-work Details | Review
Add new macro GNOME_DISABLE_DEPRECATED (1.76 KB, patch)
2010-02-14 04:07 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Add new macro GNOME_DISABLE_DEPRECATED.v2 (1.83 KB, patch)
2010-02-24 02:49 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Add new macro GNOME_DISABLE_DEPRECATED.v3 (2.09 KB, patch)
2010-02-24 04:51 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review

Description Javier Jardón (IRC: jjardon) 2010-02-13 05:12:33 UTC 
Rename GNOME_MAINTAINER_MODE_DEFINES to GNOME_DISABLE_DEPRECATED

It (GNOME_MAINTAINER_MODE_DEFINES) does is pretty disconnected from what AM_MAINTAINER_MODE does. They share a nebulous concept of a "maintainer mode", but they're doing very different things.

Also, the use of AM_MAINTAINER_MODE is not encouraged, see [1] 

[1] http://www.gnu.org/software/hello/manual/automake/maintainer_002dmode.html
Comment 1 Javier Jardón (IRC: jjardon) 2010-02-13 05:13:40 UTC 
Created attachment 153688 [details] [review]
Replace GNOME_MAINTAINER_MODE_DEFINES with GNOME_DISABLE_DEPRECATED
Comment 2 Christian Persch 2010-02-13 12:40:40 UTC 
Comment on attachment 153688 [details] [review]
Replace GNOME_MAINTAINER_MODE_DEFINES with GNOME_DISABLE_DEPRECATED

We need to keep the old macro for compatibility (otherwise all modules using it will break). Just forwarding to the new macro is fine of course, maybe with a AC_MSG_WARN([... deprecated...]).
Comment 3 Javier Jardón (IRC: jjardon) 2010-02-14 04:07:32 UTC 
Created attachment 153747 [details] [review]
Add new macro GNOME_DISABLE_DEPRECATED

What about this?
I've created an alias, so everybody will use the correct macro
Comment 4 Christian Persch 2010-02-17 22:31:21 UTC 
The alias looks fine to me.

The behaviour change in that this now always defines these flags instead of just in maintainer mode isn't ok however. Should we add a AC_ARG_ENABLE flag for this?
Comment 5 Javier Jardón (IRC: jjardon) 2010-02-24 02:49:00 UTC 
Created attachment 154560 [details] [review]
Add new macro GNOME_DISABLE_DEPRECATED.v2

Use AC_ARG_ENABLE, so you can use --enable-deprecated to not apply the flags
Comment 6 Javier Jardón (IRC: jjardon) 2010-02-24 04:51:38 UTC 
Created attachment 154565 [details] [review]
Add new macro GNOME_DISABLE_DEPRECATED.v3

Sorry, the previous patch was wrong.

Here a new one using AC_ARG_ENABLE correctly
Comment 7 Christian Persch 2010-05-30 21:00:10 UTC 
Bug 614360 is about the same thing and has interesting comments, so I'm duping this way.

*** This bug has been marked as a duplicate of bug 614360 ***