After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609649 - [regression] Doesn't emit cal-opened on password prompt cancel
[regression] Doesn't emit cal-opened on password prompt cancel
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
evolution[dbus]
Depends on:
Blocks:
 
 
Reported: 2010-02-11 14:20 UTC by Milan Crha
Modified: 2013-09-14 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eds patch (1.87 KB, patch)
2010-02-12 12:12 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2010-02-11 14:20:30 UTC
I found out that the "cal-opened" signal is not emitted when a user is asked for a password and he/she cancels the prompt. In this case the signal is never emitted, and for example itip-formatter is thinking it's doing something, but it isn't, in an "infinite" waiting.

Steps:
a) either forget a password on one of your remote calendars which requires
   a password or configure for example a fake CalDAV calendar with:
   url: caldav://aaa.bbb.ccc/ddd
   username: xxx
b) on any prompt for a password on this calendar hit Cancel (or press Esc)
c) go to mailer
d) select a meeting invitation mail

itip-formatter is using all configured calendars to check whether the event is already stored there, doing e_cal_open_async and "waiting" until all calendars are opened, either properly or not, discovering this in cal-opened signal handler. As this is never called when one cancels the password prompt, itip-formatter never finishes its waiting for the signal (which is done async, thus the backtrace doesn't show anything, and CPU usage is low).

The 2.28 works properly in this case, so I'm calling this a regression.
Comment 1 Milan Crha 2010-02-12 12:12:44 UTC
Created attachment 153621 [details] [review]
eds patch

for evolution-data-server;

Making this work as expected, plus couple related fixed around.
Comment 2 Milan Crha 2010-02-12 12:17:46 UTC
Created commit 798df06 in eds master (2.29.91+)

+ commit 35b167f in evo master (2.29.91+) to show a reason of failed calendar open in an itip-formatter. No string added, no string change, thus should be safe.