After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609547 - Values of stocks are displayed without currency
Values of stocks are displayed without currency
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: invest-applet
git master
Other Linux
: Normal minor
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-10 15:03 UTC by Enrico Minack
Modified: 2010-07-07 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
currency of stocks are also displayed now (4.95 KB, patch)
2010-02-10 15:03 UTC, Enrico Minack 		none Details | Review

Description Enrico Minack 2010-02-10 15:03:33 UTC 
Created attachment 153423 [details] [review]
currency of stocks are also displayed now

Different stock symbols provide stock values from different markets in different countries with different currencies, but the widget only shows the number and no currency information.

This patch makes the invest applet to retrieve the currency of stocks, to use the currency in the widget, writes all numbers aligned to the right, and it fixes a bug in yahoo's data for currency conversions like EURJPY=X.
Comment 1 Matteo Zandi 2010-02-13 09:46:30 UTC 
This is a major improvement, very nice, some other ideas that might improve it further:

- when adding a new ticker in the preferences dialog, the user should know in which currency the stock is displayed, so that he can enter the price in the right currency (see bug #608842, it could be easily retrieved like the ticker label). 

- if we allow to specify the exchange rate at time of purchase when adding a new stock, we could calculate a correct 'positions balance' in one single currency. User should be able to select his local currency and invest should take care of converting gain amounts in the local currency and display them accordingly in the popup window.
Comment 2 Enrico Minack 2010-02-13 22:02:08 UTC 
Regarding the first comment, I would rather think the user should add the symbol of the market where the stocks were purchased. This means, the identical currency has to be entered. It should be obvious, which currency this is.

Regarding the second comment, I have a working patch that lets the user specify a local currency and the applet retrieves all necessary conversion rates and computes all stocks' value in the in that local currency. Together with my comment on the first remark, this should do the job quite nicely.

I think an improved documentation (that there are different market symbols for the same stock leading to different currencies, which currencies to enter, the currency conversion) should make this issue being solved.

The respective patch will be added to bug #339127, so see there for tracking its progress.
Comment 3 Enrico Minack 2010-02-17 18:12:22 UTC 
I agree that if the shares are bought and commission is paid in a forreign currency, then the current balance in local currency can only be computed using the current exchange rate and the exchange rate at the time of the purchase.

For this, I also added an exchange column to the preferences window if a local currency is given. Then, the buy value and commission can be given in a foreign currency, together with the exchange rate at that time, so that the current value and balance is computed properly in the local currency. See bug #339127 for details.