After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609498 - Modernize autotools configuration
Modernize autotools configuration
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: Build
2.91.x
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-10 05:29 UTC by Javier Jardón (IRC: jjardon)
Modified: 2015-09-24 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Modernize autotools configuration (5.51 KB, patch)
2010-02-10 05:31 UTC, Javier Jardón (IRC: jjardon)
needs-work Details | Review
Modernize autotools configuration.v2 (4.61 KB, patch)
2010-04-15 22:53 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Use the new libtool syntax (717 bytes, patch)
2011-03-05 18:47 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Do not use deprecated GNOME_COMMON_INIT (764 bytes, patch)
2011-03-05 18:48 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Replace some deprecated macros (1.20 KB, patch)
2011-03-05 18:48 UTC, Javier Jardón (IRC: jjardon)
reviewed Details | Review
Use upstream gettext instead the Glib one (1010 bytes, patch)
2011-03-05 18:49 UTC, Javier Jardón (IRC: jjardon)
reviewed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-02-10 05:29:55 UTC
See http://live.gnome.org/GnomeGoals/ModernAutotools
Comment 1 Javier Jardón (IRC: jjardon) 2010-02-10 05:31:06 UTC
Created attachment 153384 [details] [review]
Modernize autotools configuration

New requirements:

    autoconf >= 2.64
    automake >= 1.10
    libtool >= 2.2.6
    intltool >= 0.40.6
Comment 2 Xan Lopez 2010-02-12 22:34:59 UTC
Comment on attachment 153384 [details] [review]
Modernize autotools configuration

autoconf 2.64 seems a bit excesive, I don't even have that installed and I use Fedora 12.

Also you seem to mix some updates with apparently pointless name changes, not sure I see the point. Perhaps you should do smaller patches explaining why you do each thing?
Comment 3 Javier Jardón (IRC: jjardon) 2010-04-15 22:53:36 UTC
Created attachment 158859 [details] [review]
Modernize autotools configuration.v2

Here a more conservative patch:

New requirements:

autoconf >= 2.63 
   (2.64 is available in jhbuild id you still want it)

automake >= 1.11
   Previous versions are affected by a security bug. See http://lists.gnu.org/archive/html/automake/2009-12/msg00012.html

libtool >= 2.2.6

   Needed to use the new libtool syntax

intltool >= 0.41

   Some devels reported that previous versions have problems with some xml files

Also, I've used the GNOME_MAINTEINER_MODE_DEFINES gnome-common macro instead custom code.
Comment 4 Xan Lopez 2010-04-21 18:28:04 UTC
It seems to me that there's a few things in the patch that can be landed without really modifying the autotools requirements (changes in autogen.sh, the GNOME_MAINTANER_MODE_DEFINES?). I'd like to land those separatedly.

Then you can do another patch where we see exactly what is improved by updating the requirements of each tool and why we should do it. In general all seems pretty minor.
Comment 5 Javier Jardón (IRC: jjardon) 2011-03-05 18:47:58 UTC
Created attachment 182563 [details] [review]
Use the new libtool syntax
Comment 6 Javier Jardón (IRC: jjardon) 2011-03-05 18:48:26 UTC
Created attachment 182564 [details] [review]
Do not use deprecated GNOME_COMMON_INIT
Comment 7 Javier Jardón (IRC: jjardon) 2011-03-05 18:48:55 UTC
Created attachment 182565 [details] [review]
Replace some deprecated macros
Comment 8 Javier Jardón (IRC: jjardon) 2011-03-05 18:49:20 UTC
Created attachment 182566 [details] [review]
Use upstream gettext instead the Glib one
Comment 9 Gustavo Noronha (kov) 2011-03-16 22:42:15 UTC
Review of attachment 182563 [details] [review]:

No change to requirements at all, I'll say go!
Comment 10 Gustavo Noronha (kov) 2011-03-16 22:44:19 UTC
Review of attachment 182564 [details] [review]:

Looks sane. Could you please add the bug reference to the commit messages, btw?
Comment 11 Gustavo Noronha (kov) 2011-03-16 22:46:50 UTC
Review of attachment 182565 [details] [review]:

Looks good in general.

::: configure.ac
@@ -228,3 @@
 AC_MSG_CHECKING([location of system Certificate Authority list])
 AC_ARG_WITH(ca-file,
-            [AC_HELP_STRING([--with-ca-file=@<:@path@:>@],

I can't spot what's changed here, is it indentation?
Comment 12 Gustavo Noronha (kov) 2011-03-16 22:49:14 UTC
Review of attachment 182566 [details] [review]:

It seems to make sense, but why would we want this? The other changes are fairly obvious, but I don't really understand this one, some detailing on the commit message would be great.
Comment 13 Javier Jardón (IRC: jjardon) 2011-03-17 02:41:31 UTC
Comment on attachment 182563 [details] [review]
Use the new libtool syntax

commit aae3c1a662d4556e0284a85cfe8d3f47a09491ba
Comment 14 Javier Jardón (IRC: jjardon) 2011-03-17 02:41:57 UTC
Comment on attachment 182564 [details] [review]
Do not use deprecated GNOME_COMMON_INIT

commit 5b709dfed1a48b3acab03624fcb757ec874e9f83
Comment 15 Javier Jardón (IRC: jjardon) 2011-03-17 02:42:43 UTC
(In reply to comment #11)

> ::: configure.ac
> @@ -228,3 @@
>  AC_MSG_CHECKING([location of system Certificate Authority list])
>  AC_ARG_WITH(ca-file,
> -            [AC_HELP_STRING([--with-ca-file=@<:@path@:>@],
> 
> I can't spot what's changed here, is it indentation?

AC_HELP_STRING -> AS_HELP_STRING
Comment 16 Javier Jardón (IRC: jjardon) 2011-03-17 02:44:54 UTC
(In reply to comment #12)
> Review of attachment 182566 [details] [review]:
> 
> It seems to make sense, but why would we want this? The other changes are
> fairly obvious, but I don't really understand this one, some detailing on the
> commit message would be great.

Take a look to this blog post: http://blogs.gnome.org/jjardon/2010/10/08/use-upstream-gettext-instead-the-glib-one/

Thanks for your reviews!!