GNOME Bugzilla – Bug 609498
Modernize autotools configuration
Last modified: 2015-09-24 18:14:14 UTC
See http://live.gnome.org/GnomeGoals/ModernAutotools
Created attachment 153384 [details] [review] Modernize autotools configuration New requirements: autoconf >= 2.64 automake >= 1.10 libtool >= 2.2.6 intltool >= 0.40.6
Comment on attachment 153384 [details] [review] Modernize autotools configuration autoconf 2.64 seems a bit excesive, I don't even have that installed and I use Fedora 12. Also you seem to mix some updates with apparently pointless name changes, not sure I see the point. Perhaps you should do smaller patches explaining why you do each thing?
Created attachment 158859 [details] [review] Modernize autotools configuration.v2 Here a more conservative patch: New requirements: autoconf >= 2.63 (2.64 is available in jhbuild id you still want it) automake >= 1.11 Previous versions are affected by a security bug. See http://lists.gnu.org/archive/html/automake/2009-12/msg00012.html libtool >= 2.2.6 Needed to use the new libtool syntax intltool >= 0.41 Some devels reported that previous versions have problems with some xml files Also, I've used the GNOME_MAINTEINER_MODE_DEFINES gnome-common macro instead custom code.
It seems to me that there's a few things in the patch that can be landed without really modifying the autotools requirements (changes in autogen.sh, the GNOME_MAINTANER_MODE_DEFINES?). I'd like to land those separatedly. Then you can do another patch where we see exactly what is improved by updating the requirements of each tool and why we should do it. In general all seems pretty minor.
Created attachment 182563 [details] [review] Use the new libtool syntax
Created attachment 182564 [details] [review] Do not use deprecated GNOME_COMMON_INIT
Created attachment 182565 [details] [review] Replace some deprecated macros
Created attachment 182566 [details] [review] Use upstream gettext instead the Glib one
Review of attachment 182563 [details] [review]: No change to requirements at all, I'll say go!
Review of attachment 182564 [details] [review]: Looks sane. Could you please add the bug reference to the commit messages, btw?
Review of attachment 182565 [details] [review]: Looks good in general. ::: configure.ac @@ -228,3 @@ AC_MSG_CHECKING([location of system Certificate Authority list]) AC_ARG_WITH(ca-file, - [AC_HELP_STRING([--with-ca-file=@<:@path@:>@], I can't spot what's changed here, is it indentation?
Review of attachment 182566 [details] [review]: It seems to make sense, but why would we want this? The other changes are fairly obvious, but I don't really understand this one, some detailing on the commit message would be great.
Comment on attachment 182563 [details] [review] Use the new libtool syntax commit aae3c1a662d4556e0284a85cfe8d3f47a09491ba
Comment on attachment 182564 [details] [review] Do not use deprecated GNOME_COMMON_INIT commit 5b709dfed1a48b3acab03624fcb757ec874e9f83
(In reply to comment #11) > ::: configure.ac > @@ -228,3 @@ > AC_MSG_CHECKING([location of system Certificate Authority list]) > AC_ARG_WITH(ca-file, > - [AC_HELP_STRING([--with-ca-file=@<:@path@:>@], > > I can't spot what's changed here, is it indentation? AC_HELP_STRING -> AS_HELP_STRING
(In reply to comment #12) > Review of attachment 182566 [details] [review]: > > It seems to make sense, but why would we want this? The other changes are > fairly obvious, but I don't really understand this one, some detailing on the > commit message would be great. Take a look to this blog post: http://blogs.gnome.org/jjardon/2010/10/08/use-upstream-gettext-instead-the-glib-one/ Thanks for your reviews!!