After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609463 - Distorted sound when the equalizer is enabled
Distorted sound when the equalizer is enabled
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: GStreamer
1.5.3
Other Linux
: Normal trivial
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 614630 614654 616074 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-02-09 21:21 UTC by Aleksander Gielnicki
Modified: 2010-11-04 23:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sound distortion recording (through an iSight mic) (297.20 KB, audio/x-flac)
2010-03-13 17:21 UTC, Jacob
  Details
equalizer patch - Maintain precision as much as possible, move floor call to the last possible time to do so (2.37 KB, patch)
2010-08-25 02:50 UTC, Zhou Ting
none Details | Review

Description Aleksander Gielnicki 2010-02-09 21:21:58 UTC
When you change presets while a song is playing, the overall +db ramps up. Or maybe just the lower frequencies, the audible part is that the sound goes PFRRRRRT on bass sounds. I hope it's understandable, 'cause English is not my native language. ;)

It goes away after changing songs and the correct equalizer values are set.
Comment 1 Jacob 2010-03-13 17:19:22 UTC
Confirmed.

I'd been chasing this bug for weeks, and then when I finally played something through mplayer I realized it was Banshee's problem. I dug through Bugzilla (a blind search for "sound") and this bug comes up. I check Banshee's Equalizer settings and sure enough "Pop" was set and it was "Enabled". I disabled the Equalizer and now everything is good again.
Comment 2 Jacob 2010-03-13 17:21:47 UTC
Created attachment 156066 [details]
Sound distortion recording (through an iSight mic)
Comment 3 Michael Martin-Smucker 2010-03-13 17:47:17 UTC
Part of Bug 612669 is a duplicate of this, and it has a bit more discussion.  I'm leaving that one open because it also addresses a related issue with the equalizer.

Some highlights from bug 612669:

This issue was also brought up on the mailing list: http://mail.gnome.org/archives/banshee-list/2010-March/msg00091.html

(From bug# 612669 comment #8)
> I can reproduce this bug by just enabling the equaliser and switching between
> presets. The strange thing is that the same preset does not always result in
> distorted sound but after some switching it normally does.
Comment 4 Alexander Kojevnikov 2010-04-02 03:17:35 UTC
*** Bug 614630 has been marked as a duplicate of this bug. ***
Comment 5 Alexander Kojevnikov 2010-04-07 22:36:44 UTC
*** Bug 614654 has been marked as a duplicate of this bug. ***
Comment 6 Alexander Kojevnikov 2010-04-18 09:17:34 UTC
*** Bug 614630 has been marked as a duplicate of this bug. ***
Comment 7 Alexander Kojevnikov 2010-04-18 09:17:38 UTC
*** Bug 616074 has been marked as a duplicate of this bug. ***
Comment 8 Michael Martin-Smucker 2010-07-05 13:59:26 UTC
*** Bug 623596 has been marked as a duplicate of this bug. ***
Comment 9 Zhou Ting 2010-08-25 02:50:56 UTC
Created attachment 168696 [details] [review]
equalizer  patch - Maintain precision as much as possible, move floor call to the last possible time to do so 

I migrate an upstream gstreamer equalizer patch to banshee. This patch can
resolve the distortion issue in my env. 

Attachment is the patch for banshee. The upstream defect is:
https://bugzilla.gnome.org/show_bug.cgi?id=580214
Comment 10 Gabriel Burt 2010-08-29 21:18:46 UTC
What upstream commit is this from?  Are you sure you're using Banshee's bundled eq element?  At runtime, at least with --debug passed, we log whether we are using it or not.
Comment 11 Gabriel Burt 2010-09-20 22:51:24 UTC
Zhou Ting, ping?
Comment 12 Zhou Ting 2010-11-04 04:17:12 UTC
(In reply to comment #10)
> What upstream commit is this from?  Are you sure you're using Banshee's bundled
> eq element?  At runtime, at least with --debug passed, we log whether we are
> using it or not.




I'm sorry for the quite late response, I missed the email.


This is the link of upstream commit in gst-plugins-good
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=9507cdc84c968dc142356157c861e8d216b85716

Turning on banshee debug log cannot get useful information for this problem.

In gentoo bugzila, they also proved the problem exist in banshee 1.8.0, yet the patch can resolve the problem. 
http://bugs.gentoo.org/show_bug.cgi?id=310233
Comment 13 Gabriel Burt 2010-11-04 23:11:03 UTC
Thanks Zhou Ting, committed to master and stable-1.8.