After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609458 - --enable-icon-mapping=yes doesn't work
--enable-icon-mapping=yes doesn't work
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
git master
Other Linux
: Normal blocker
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2010-02-09 20:18 UTC by Luca Ferretti
Modified: 2010-03-26 11:42 UTC
See Also:
GNOME target: 2.30.x
GNOME version: ---

Attachments
Proposed patch (1.87 KB, patch)
2010-03-24 20:17 UTC, Luca Ferretti 		none Details | Review

Description Luca Ferretti 2010-02-09 20:18:44 UTC 
As per summary, specifying --enable-icon-mapping=yes in g-i-t from git master doesn't create link to "fallback" icons (gtk-* and other).
Comment 1 Jakub Steiner 2010-03-03 17:58:44 UTC 
I'm affraid I'm unable to resolve this one :/ Patches very welcome :)
Comment 2 Luca Ferretti 2010-03-24 20:17:22 UTC 
Created attachment 157017 [details] [review]
Proposed patch

Very rough, but working. I suppose we should commit it in order to include new g-i-t in GNOME 2.30...
Comment 3 Jakub Steiner 2010-03-25 15:14:15 UTC 
Applied the patch and released 2.29.3. Thanks Luca.
Comment 4 André Klapper 2010-03-26 09:45:42 UTC 
Please do note that GNOME is under Hardcode Freeze hence such commits need approval from two release-team members first (however in this case I'm personally fine with having this fixed - just for future reference).
Comment 5 Jakub Steiner 2010-03-26 11:20:20 UTC 
My bad, should I still mail release-team with this?
Comment 6 André Klapper 2010-03-26 11:42:25 UTC 
Not needed. Just blame me if someone complains afterwards. :-)