After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609444 - Make/Model profile metadata for input profiles
Make/Model profile metadata for input profiles
Status: RESOLVED FIXED
Product: gnome-color-manager
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: gnome-color-manager-maint
gnome-color-manager-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-09 17:21 UTC by Pascal de Bruijn
Modified: 2010-02-12 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pascal de Bruijn 2010-02-09 17:21:51 UTC
When profiling input (e.g. digital camera RAW images), GCM currently uses the connected device info to fill the ICC Make/Model description tags...

This can give odd results, since the connected device info is not "accurate":

  model=Canon Digital Camera
  manufacturer=Canon Inc.

While it should be something like this (from EXIF):

  model=Canon EOS 400D DIGITAL
  manufacturer=Canon

Since nautilus already depends on libexif12, I don't see a real problem with GCM depending on it as well.
Comment 1 Richard Hughes 2010-02-09 19:19:14 UTC
Is the EXIF data preserved when you save the RAW file as a TIFF in GIMP?
Comment 2 Pascal de Bruijn 2010-02-09 19:26:01 UTC
No clue... GIMP has it's limitations...

But GIMP has actually very little to do with input profiles...

Input profiles should be applied by (generated from) UFRaw/Rawstudio/Darktable/XSANE... Not GIMP...
Comment 3 Richard Hughes 2010-02-12 13:29:49 UTC
(In reply to comment #0)
> When profiling input (e.g. digital camera RAW images), GCM currently uses the
> connected device info to fill the ICC Make/Model description tags...
> 
> This can give odd results, since the connected device info is not "accurate":
> 
>   model=Canon Digital Camera
>   manufacturer=Canon Inc.
> 
> While it should be something like this (from EXIF):
> 
>   model=Canon EOS 400D DIGITAL
>   manufacturer=Canon

Okay, I've added the required code to do this, we just need to decide on policy. What happens if the tiff file contains no EXIF data? What happens if the EXIF metadata is wrong, but the device data is correct? Do we need UI to give the user a choice?
Comment 4 Pascal de Bruijn 2010-02-12 13:42:19 UTC
I don't think EXIF is easily wrong for camera's... 

I'm not sure about scanners, this is highly dependent on XSANE/GNOME-Scan.

If no data is included, we should probably fall back to device data.
Comment 5 Richard Hughes 2010-02-12 14:22:47 UTC
commit fc3c8a522ed2ad0d68f603729399233b7e62572f
Author: Richard Hughes <richard@hughsie.com>
Date:   Fri Feb 12 14:21:48 2010 +0000

    Automatically use the EXIF data if available from TIFF files when calibrating devices. Fixes #609444

Please test and verify. Thanks.