After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609418 - Update dates copyright strings
Update dates copyright strings
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: 2.26.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2010-02-09 13:22 UTC by Pablo Castellano (IRC: pablog)
Modified: 2018-03-09 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
help dialog (47.08 KB, image/png)
2010-02-09 13:22 UTC, Pablo Castellano (IRC: pablog) 		  Details
copyright_strings.txt (18.08 KB, text/plain)
2010-02-09 13:23 UTC, Pablo Castellano (IRC: pablog) 		  Details
0001-Updated-year-in-the-copyright-string-of-the-about-di.patch (1.15 KB, patch)
2010-02-12 04:03 UTC, Pablo Castellano (IRC: pablog) 		committed Details | Review

Description Pablo Castellano (IRC: pablog) 2010-02-09 13:22:20 UTC 
Created attachment 153325 [details]
help dialog

There are a lot of old copyright strings.
Maybe the most important is the one from the help dialog, which gives aspect of unmaintenance.

Is it enough changing them just by adding "$YEAR - 2010" ?
Comment 1 Pablo Castellano (IRC: pablog) 2010-02-09 13:23:40 UTC 
Created attachment 153326 [details]
copyright_strings.txt
Comment 2 Adam Schreiber 2010-02-12 01:53:18 UTC 
I agree with updating the About dialog.  I'm not sure what's the appropriate course of action for the code files.
Comment 3 Pablo Castellano (IRC: pablog) 2010-02-12 04:03:25 UTC 
Created attachment 153601 [details] [review]
0001-Updated-year-in-the-copyright-string-of-the-about-di.patch

First trivial patch
Comment 4 Adam Schreiber 2010-02-13 02:39:57 UTC 
Review of attachment 153601 [details] [review]:

Looks good to commit.
Comment 5 Pablo Castellano (IRC: pablog) 2010-02-13 03:16:05 UTC 
Comment on attachment 153601 [details] [review]
0001-Updated-year-in-the-copyright-string-of-the-about-di.patch

Committed, there's still the issue with the copyright years in the source.

commit 149434f8d13415ab16866534bcd9a70a2665d1be
Author: Pablo Castellano <pablog@src.gnome.org>
Date:   Fri Feb 12 05:00:21 2010 +0100

    Updated year in the copyright string of the about dialog
    
    Part of: https://bugzilla.gnome.org/show_bug.cgi?id=609418
Comment 6 Niels De Graef 2018-03-09 20:06:20 UTC 
About dialog fixed as of commit 130725a9 on master.

Wrt to the code files: I'm not really a fan of updating source code just to update the copyright symbol: it make it hard to view on the file level when and why it was last edited.