Created attachment 153273 [details] [review]
Initialize global->root_pixmap to the stage color

Fixes drawing of the overview in the case where there is no root pixmap
(eg, --xephyr mode).

should have clarified; the workaround for not drawing an uninitialized texture becomes unnecessary, since the texture would never be uninitialized now

Review of attachment 153273 [details] [review]:

Looks fine. Perhaps obviously The "the workaround for not drawing an uninitialized texture
becomes unnecessary, since the texture would never be uninitialized now" should be included in the commit message.

::: src/shell-global.c
@@ +1035,3 @@
+      clutter_texture_set_from_rgb_data (CLUTTER_TEXTURE (global->root_pixmap),
+                                         (const guchar *)&stage_color, FALSE,
+                                         1, 1, 3, 3, 0, NULL);

Grumble :-). OK. Could use a /* width, height, rowstride, bpp, flags */
on the mysterious series of numbers. Could probably use a /* first three bytes of ClutterColor structure are RGB */ to explain the cast.

updated and pushed

Attachment 153273 [details] pushed as 8e759d7 - Initialize global->root_pixmap to the stage color