After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609319 - Disable Empathy's "Contact goes online" and "Contact goes offline" sound notifications by default
Disable Empathy's "Contact goes online" and "Contact goes offline" sound noti...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Preferences
2.29.x
Other Linux
: Normal trivial
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-08 12:52 UTC by Vish
Modified: 2010-02-09 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
disable login & logout sound events by default (773 bytes, patch)
2010-02-08 15:32 UTC, Frederic Peters
accepted-commit_now Details | Review

Description Vish 2010-02-08 12:52:06 UTC
Bug first reported in launchpad >
https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/516804

"For users with more than a hundred contacts, Emapthy's "Contact goes online" and "Contact goes offline" will play nearly 4 times every minute, assuming every contact signs on and off once every 12 hours. Inundating the user with intrusive audible notifications that convey very little information is not a sane default."
Comment 1 Frederic Peters 2010-02-08 13:26:36 UTC
The schema defaults both options to "false"; perhaps this is an ubuntu patch?

    <schema>
      <key>/schemas/apps/empathy/notifications/notifications_contact_signin</key>
      <applyto>/apps/empathy/notifications/notifications_contact_signin</applyto>
      <owner>empathy</owner>
      <type>bool</type>
      <default>false</default>
      <locale name="C">
         <short>Pop up notifications when a contact logs in</short>
         <long>
         Whether to show a popup notification when a contact goes
         online.
         </long>
      </locale>
    </schema>

    <schema>
      <key>/schemas/apps/empathy/notifications/notifications_contact_signout</key>
      <applyto>/apps/empathy/notifications/notifications_contact_signout</applyto>
      <owner>empathy</owner>
      <type>bool</type>
      <default>false</default>
      <locale name="C">
         <short>Pop up notifications when a contact logs out</short>
         <long>
         Whether to show a popup notification when a contact goes
         offline.
         </long>
      </locale>
    </schema>
Comment 2 Vish 2010-02-08 13:39:06 UTC
thanks for pointing that out.
I'll mention it on launchpad
Comment 3 Sebastien Bacher 2010-02-08 15:21:02 UTC
the schemas you listed are not the sounds ones which are on by default
Comment 4 Frederic Peters 2010-02-08 15:32:45 UTC
Created attachment 153269 [details] [review]
disable login & logout sound events by default

Oh sorry, I have been working without any sound events for so long I didn't even spot the "sound" in the bug title.

Here is a patch, if it makes sense to the maintainers. (as I don't know if "users with more than a hundred contacts" are the users default settings should address).
Comment 5 Guillaume Desmottes 2010-02-09 11:33:38 UTC
Review of attachment 153269 [details] [review]:

Makes sense to me. Please merge (don't forget to include the bug number in your commit msg).
Comment 6 Frederic Peters 2010-02-09 11:47:24 UTC
commit fe9e7dd4083299e534a1f82be51d4d092237f994
Author: Frédéric Péters <fpeters@0d.be>
Date:   Tue Feb 9 12:44:08 2010 +0100

    Disable sound notifications for login/logout of contacts (#609319)