GNOME Bugzilla – Bug 609252
[theoradec] Doesn't handle unknown pixel aspect ratio properly
Last modified: 2010-02-13 12:35:08 UTC
Created attachment 153209 [details] [review] patch to fix handling of 0:x PAR gsttheoradec.c currently says of the pixel aspect ratio """ * 0:0 is allowed and can be interpreted as 1:1, so correct for it. * x:0 for other x isn't technically allowed, but it's seen in the wild and * is reasonable to treat the same """ 0:x is treated as 0/x = 0. This is not correct. The Theora spec says """ If either of these fields are zero, this indicates that pixel aspect ratio information was not available to the encoder. In this case it MAY be specified by the application via an external means, or a default value of 1 : 1 MAY be used. """ With the current behavior, I believe a file with PAR 0:x fails to play, and produces errors like ** (totem:14347): CRITICAL **: gst_video_calculate_display_ratio: assertion `num > 0' failed Attached is a patch to follow the spec.
Comment on attachment 153209 [details] [review] patch to fix handling of 0:x PAR The patch looks good. Tim, can we get this into 0.10.26? Looks simple enough
*** Bug 609249 has been marked as a duplicate of this bug. ***
Thanks for the patch. It would be great if you could next time submit a patch created with 'git format-patch -1' - that way I don't have to type in a commit message and the author information :) commit a09d9fdece3983a79e4d5a1ccb1ef55a21e158e1 Author: Benjamin M. Schwartz <bens@alum.mit.edu> Date: Mon Feb 8 11:21:35 2010 +0100 theoradec: PARs of 0:x, x:0 and 0:0 are all allowed and map to 1:1 Fixes #609252.
*** Bug 609788 has been marked as a duplicate of this bug. ***