After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609177 - [PATCH] src/gpm-brightness-hal.c: error is not declared (line 498)
[PATCH] src/gpm-brightness-hal.c: error is not declared (line 498)
Status: RESOLVED OBSOLETE
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-manager
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-02-06 17:46 UTC by Romain Perier
Modified: 2011-03-04 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-power-manager-2.29.3-brightness-hal-missing-decl.patch (543 bytes, patch)
2010-02-06 17:47 UTC, Romain Perier
accepted-commit_now Details | Review

Description Romain Perier 2010-02-06 17:46:46 UTC
Hey,

when I cloned the repository this afternoon I found an issue building gpm with hal support, see yourself:

  CC     gnome_power_preferences-gpm-prefs.o
  CC     gnome_power_preferences-gpm-prefs-core.o
  CC     gnome_power_statistics-gpm-statistics.o
  CC     gnome_power_statistics-gpm-point-obj.o
  CC     gnome_power_statistics-gpm-graph-widget.o
  AR     libgpmshared.a
gpm-brightness-hal.c: In function ‘gpm_brightness_hal_init’:
gpm-brightness-hal.c:498: erreur: ‘error’ undeclared (first use in this function)
gpm-brightness-hal.c:498: erreur: (Each undeclared identifier is reported only once
gpm-brightness-hal.c:498: erreur: for each function it appears in.)
make[3]: *** [gnome_power_manager-gpm-brightness-hal.o] Erreur 1
make[3]: *** Attente des tâches non terminées....
gpm-prefs-core.c:862: attention : ‘gpm_prefs_set_defaults_cb’ defined but not used
make[3]: quittant le répertoire « /var/tmp/portage/gnome-extra/gnome-power-manager-9999/work/gnome-power-manager-9999/src »
make[2]: *** [all] Erreur 2
make[2]: quittant le répertoire « /var/tmp/portage/gnome-extra/gnome-power-manager-9999/work/gnome-power-manager-9999/src »
make[1]: *** [all-recursive] Erreur 1
make[1]: quittant le répertoire « /var/tmp/portage/gnome-extra/gnome-power-manager-9999/work/gnome-power-manager-9999 »
make: *** [all] Erreur 2

The fix is pretty trivial, you just forgot to declare "error" (GError *),
see the attached patch.

Regards,
mrpouet
Comment 1 Romain Perier 2010-02-06 17:47:33 UTC
Created attachment 153152 [details] [review]
gnome-power-manager-2.29.3-brightness-hal-missing-decl.patch
Comment 2 Richard Hughes 2010-02-08 09:28:04 UTC
Review of attachment 153152 [details] [review]:

Thanks!
Comment 3 André Klapper 2011-03-04 12:19:57 UTC
Wasn't HAL support completely removed in the meantime, so the patch (and the report here) do not apply anymore and should be closed as OBSOLETE?
Comment 4 Richard Hughes 2011-03-04 13:50:49 UTC
(In reply to comment #3)
> Wasn't HAL support completely removed in the meantime, so the patch (and the
> report here) do not apply anymore and should be closed as OBSOLETE?

Yup, thanks.