After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609130 - [PATCH] Fix GtkVideoPlayer example for win32
[PATCH] Fix GtkVideoPlayer example for win32
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-sharp
git master
Other Windows
: Normal normal
: 0.9.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 609816
 
 
Reported: 2010-02-05 23:00 UTC by Andoni Morales
Modified: 2010-02-13 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-GtkVideoPlayer-Fix-the-way-file-uri-is-set-in-win32 (1.33 KB, patch)
2010-02-05 23:00 UTC, Andoni Morales
committed Details | Review
0002-GtkVideoPlayer-Invoke-native-functions-if-the-the-vi (2.18 KB, patch)
2010-02-05 23:01 UTC, Andoni Morales
none Details | Review
0002-GtkVideoPlayer-Invoke-native-functions-if-the-the-vi (2.16 KB, patch)
2010-02-05 23:04 UTC, Andoni Morales
rejected Details | Review

Description Andoni Morales 2010-02-05 23:00:45 UTC
Created attachment 153113 [details] [review]
0001-GtkVideoPlayer-Fix-the-way-file-uri-is-set-in-win32

The current GtkVideoPlayer example doesn't set the uri properly on win32.
It should set uri=file:///c:/file/path, with one slash before c:/, and the backslashes must be replaced by slahes.
The windows sinks, dshowvideosink and directdrawsink are not casted to XOverlay. If that happens, invoke the native functions.
Comment 1 Andoni Morales 2010-02-05 23:01:38 UTC
Created attachment 153114 [details] [review]
0002-GtkVideoPlayer-Invoke-native-functions-if-the-the-vi
Comment 2 Andoni Morales 2010-02-05 23:04:15 UTC
Created attachment 153115 [details] [review]
0002-GtkVideoPlayer-Invoke-native-functions-if-the-the-vi
Comment 3 Sebastian Dröge (slomo) 2010-02-06 09:22:43 UTC
(In reply to comment #2)
> Created an attachment (id=153115) [details] [review]
> 0002-GtkVideoPlayer-Invoke-native-functions-if-the-the-vi

I don't like this patch, the real solution would be to add bindings for dshowvideosink and directdrawsink.  Could you create them? Just take a look at how the CorePlugins bindings are done for example, it's more or less done automatically.
Comment 4 Sebastian Dröge (slomo) 2010-02-06 09:23:02 UTC
If you need any help with that feel free to ask :)
Comment 5 Andoni Morales 2010-02-06 13:49:20 UTC
Indeed that's what I wanted to do. Should I create a new namespace Gst.BadPlugins?
Comment 6 Sebastian Dröge (slomo) 2010-02-06 17:15:59 UTC
(In reply to comment #5)
> Indeed that's what I wanted to do. Should I create a new namespace
> Gst.BadPlugins?

Yes, and GoodPlugins for the directdraw stuff (IIRC it's in good)
Comment 7 Sebastian Dröge (slomo) 2010-02-13 08:09:48 UTC
commit b689dd7e7bfefbeb3fc2913946b6ba53b6ea3de2
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Fri Feb 5 23:39:12 2010 +0100

    Fix the way file uri is set in win32
Comment 8 Sebastian Dröge (slomo) 2010-02-13 08:13:26 UTC
I created bug #609816 for tracking the Windows specific plugins bindings progress. If you need any help with that feel free to ask...

Also, if you provide me with the output of

elementgen/gsts-xmlinspect directdrawsink

...and the same for all other elements that you need I could add the bindings myself :)