After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609052 - Proper warning should be shown when save calendar items without summary
Proper warning should be shown when save calendar items without summary
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Punit Jain
Evolution QA team
: 353794 (view as bug list)
Depends on:
Blocks: 502515
 
 
Reported: 2010-02-05 09:22 UTC by Akhil Laddha
Modified: 2012-01-29 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screen shot (14.36 KB, image/png)
2010-02-05 09:22 UTC, Akhil Laddha
  Details
Evolution Patch (1.38 KB, patch)
2010-04-27 13:32 UTC, Punit Jain
needs-work Details | Review
Evolution Patch (2.52 KB, patch)
2010-04-28 05:53 UTC, Punit Jain
committed Details | Review

Description Akhil Laddha 2010-02-05 09:22:52 UTC
Created attachment 153063 [details]
Screen shot

evolution 2.29.6

1. Open a new task 
2. Write down description
3. Click on save
4. A warning will pop up as we haven't written summary

a) But this dialog says 'do you want to send without summary' but in actual this task will be saved locally. 

b) Dialog should have button 'save' instead of 'send'

This is valid in case of appointment also.
Comment 1 Milan Crha 2010-02-09 15:48:39 UTC
Hrm, we are under string freeze at the moment. You can ask for an approval and fix it yourself within evo/calendar/calendar.errors.xml
those are prompt-send-no-subject-calendar and prompt-send-no-subject-task. I would ignore the fact that the message ID is containing 'send' word, though fixing this as well may make it cleaner (search all the sources (in 'modules' as well for a possible inclusion of the message ID).
Comment 2 Punit Jain 2010-04-27 13:32:15 UTC
Created attachment 159691 [details] [review]
Evolution Patch
Comment 3 Bharath Acharya 2010-04-28 05:43:47 UTC
Comment on attachment 159691 [details] [review]
Evolution Patch

Change the id to save instead of send since it is used only once.

And change the secondary line to something useful to remove the recipient word.

Something like "Adding a meaningful summary to your appointment will give an idea of what your appointment is about."
Comment 4 Punit Jain 2010-04-28 05:53:37 UTC
Created attachment 159754 [details] [review]
Evolution Patch

Yes, I have changed the id and secondary line in this patch .. as id is used only once and we don't have any recipients.
Comment 5 Bharath Acharya 2010-04-28 05:58:57 UTC
Comment on attachment 159754 [details] [review]
Evolution Patch

Commit to master.
Comment 6 Bharath Acharya 2010-04-28 06:27:10 UTC
Committed to master.
Comment 7 André Klapper 2012-01-29 12:07:54 UTC
*** Bug 353794 has been marked as a duplicate of this bug. ***