After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609041 - Fix previous patch to use accessor functions
Fix previous patch to use accessor functions
Product: glade
Classification: Applications
Component: general
git master
Other All
: Normal major
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Reported: 2010-02-05 03:16 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-02-07 22:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Fix previous patch to use accessor functions (3.25 KB, patch)
2010-02-05 03:17 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-02-05 03:16:36 UTC
To replace

widget->style = gtk_style_attach (widget->style, widget->window);

I used:

gtk_widget_set_style (widget, gtk_style_attach (gtk_widget_get_style (widget), window));

but this is not correct, the correct function is:

gtk_widget_style_attach (widget);
Comment 1 Javier Jardón (IRC: jjardon) 2010-02-05 03:17:52 UTC
Created attachment 153057 [details] [review]
Fix previous patch to use accessor functions
Comment 2 Paolo Borelli 2010-02-05 07:36:17 UTC
As said before we cannot bump gtk dependency so much, since the supported version on Winows is gtk 2.16
Comment 3 Javier Jardón (IRC: jjardon) 2010-02-05 13:41:03 UTC
Hello Paolo,

Glade master already depends on GTK+ 2.19.0
Comment 4 Tristan Van Berkom 2010-02-07 21:34:46 UTC
Review of attachment 153057 [details] [review]:

Again, I didnt compile it but it looks small and ok, please go ahead and commit to master.
Comment 5 Javier Jardón (IRC: jjardon) 2010-02-07 22:54:45 UTC
Comment on attachment 153057 [details] [review]
Fix previous patch to use accessor functions

commit b5e6b7442611fc4de4276e3d095203b18d8aa287
Comment 6 Javier Jardón (IRC: jjardon) 2010-02-07 22:55:17 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thank you Tristan for the review.