After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609013 - click-hold on app icons not working
click-hold on app icons not working
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-04 19:18 UTC by William Jon McCann
Modified: 2010-03-24 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[AppDisplay] Popup the menu on left-click/hold (3.33 KB, patch)
2010-03-10 13:51 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2010-02-04 19:18:36 UTC
Looks like click-hold to bring up the appicon menu has regressed.
Comment 1 Owen Taylor 2010-02-04 21:14:43 UTC
This functionality was removed in:

http://git.gnome.org/browse/gnome-shell/commit/?id=907fc2f067c8c831ca16ef5722026ff481b8cb72

Though appIcon.js where the behavior was implemented was accidentally not removed and left around until:

http://git.gnome.org/browse/gnome-shell/commit/?id=8c178378aec921d1b3437bc0f2139f111c8624fa

Probably what happened was something like Colin implemented things in a straightforward way first and forgot to go back and pick up the special convoluted corners later.
Comment 2 Florian Müllner 2010-03-10 13:51:58 UTC
Created attachment 155746 [details] [review]
[AppDisplay] Popup the menu on left-click/hold

Left-clicking an app icon and holding the button used to pop up the
app menu, but regressed when rewriting appDisplay.
Restore the previous behavior.
Comment 3 William Jon McCann 2010-03-10 14:30:19 UTC
Cool.  Seems to work again.
Comment 4 Owen Taylor 2010-03-23 19:47:30 UTC
Review of attachment 155746 [details] [review]:

Looks good to commit except for one style thing.

::: js/ui/appDisplay.js
@@ +469,3 @@
+                if (this._menuTimeoutId != 0) {
+                    Mainloop.source_remove(this._menuTimeoutId);
+                    this._menuTimeoutId = 0;

I think I'd bundle up these lines into a _removeMenuTimeout() function. Since you have it in 5 places or so.
Comment 5 Florian Müllner 2010-03-24 18:54:49 UTC
Attachment 155746 [details] pushed as d9f43e2 - [AppDisplay] Popup the menu on left-click/hold