After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608930 - Respect button icon setting
Respect button icon setting
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
0.13.x
Other Linux
: Normal minor
: 0.14.2
Assigned To: Jean-François Fortin Tam
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-03 22:15 UTC by Michael Monreal
Modified: 2011-08-14 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Monreal 2010-02-03 22:15:11 UTC 
PiTiVi 0.13.3 does not respect GNOME's button icon setting. It just always shows icons on buttons.
Comment 1 Jean-François Fortin Tam 2010-02-04 02:44:53 UTC 
You mean that for the playback icons only, right? All other toolbars respect the gnome/gtk toolbar settings, I just tested.
Comment 2 Michael Monreal 2010-02-04 09:05:23 UTC 
Heh, no... I did not make myself clear. I was not talking about sizes etc, but /desktop/gnome/interface/buttons_have_icons=false

With this mode (gnome2.28 default), pitivi still shows icons on dialog buttons... see for example the close button in preferences or all the buttons on the bottom of the plugins window.
Comment 3 Jean-François Fortin Tam 2011-07-15 03:16:54 UTC 
How strange, I have tried looking all over the place in the code with "git grep" and can't figure out where pitivi forces the display of icons in buttons.
Comment 4 Jean-François Fortin Tam 2011-07-15 04:10:15 UTC 
Ah-ha, found it!

commit 24a13dae34de9c70bd51c39f1568454c4257dece
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Fri Sep 4 17:28:26 2009 +0200

    Force the play button to be visible, regardless of the gtk-button-images setting.
Comment 5 Jean-François Fortin Tam 2011-07-15 04:21:29 UTC 
The problem is that if we revert that commit, the play/pause button and the "clear" button (on effects and whatnot) never show. Need some fix for that.
Comment 6 Jean-François Fortin Tam 2011-07-16 01:58:09 UTC 
I have a branch that addresses this here: https://github.com/nekohayo/pitivi/commits/remove-button-icons

The problem is that the "gtk-media-play" (or gtk.STOCK_MEDIA_PLAY) icon does not show up, and I can't figure out why, it doesn't make any sense.
Comment 7 Jean-François Fortin Tam 2011-08-08 19:11:23 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Relevant commits: 1e7ae to cc974