GNOME Bugzilla – Bug 608744
Add spanish keyboard layout to caribou
Last modified: 2010-02-02 17:30:21 UTC
Created attachment 152784 [details] [review] Spanish keyboard layout patch for caribou A first crack at a spanish keyboard layout (patch attached)
Review of attachment 152784 [details] [review]: Hi Jorge, The keyboard looks good. I made a few comments on the changes you need to make. Do you mind posting an updated version of the patch with the suggested changes? Also, I noticed that the underscore label wasn't being displayed in the button. I've tracked down the problem but I will wait until this patch is committed before I make the fix. ::: src/caribou/keyboard.py @@ -80,2 +80,2 @@ # FIXME: load from stored value, default to locale appropriate - name = "caribou.keyboards.qwerty" + name = "caribou.keyboards.qwerty_es" You shouldn't include this change in the patch. When the keyboard layout selection is finished it will automatically get picked up provided the keyboard definition source file is in the correct place (which it is). ::: src/caribou/keyboards/qwerty_es.py @@ +5,3 @@ +# Copyright (C) 2009 Adaptive Technology Resource Centre +# * Contributor: Ben Konrath <ben@bagu.org> +# * Contributor: Jorge Silva <jorge.silva@utoronto.ca> You should list only yourself as a contributor since I didn't help with this keyboard :-). @@ +29,3 @@ +# TODO ensure keyboard doesn't change size when changing layers +# TODO finish numbers and punctuation layout + No need to keep any of the TODOs here, they're already in the qwerty keyboard def.
Created attachment 152845 [details] [review] Spanish keyboard layout patch for caribou v2 This patch takes into account Ben's suggestions
Review of attachment 152845 [details] [review]: Thanks Jorge, the patch has been committed to master: http://git.gnome.org/browse/caribou/commit/?id=030e407fe3fb6e7bd41822e54c64196668e39529