After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608723 - gir: Do not include generated gir files in the distribution
gir: Do not include generated gir files in the distribution
Status: VERIFIED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-02-01 20:26 UTC by Johan Bilien
Modified: 2015-02-07 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gir: Do not include generated gir files in the distribution (737 bytes, patch)
2010-02-01 20:26 UTC, Johan Bilien
committed Details | Review

Description Johan Bilien 2010-02-01 20:26:08 UTC
The generated .gir files were being added to the dist tarball. This is probably
wrong, and it would break make distcheck
Comment 1 Johan Bilien 2010-02-01 20:26:10 UTC
Created attachment 152762 [details] [review]
gir: Do not include generated gir files in the distribution
Comment 2 Rick Poyner 2010-02-01 20:37:21 UTC
Review of attachment 152762 [details] [review]:

yes, looks good.
Comment 3 Johan (not receiving bugmail) Dahlin 2010-02-01 22:45:37 UTC
It's intentional that the girs are included in the dist, it makes it possible to just get the tarball to get the GIR, you won't have to build anything. Which is pretty useful to language bindings author who doesn't want to build the whole introspection stack.

I think the proper solution is to make sure that the path where gir files are searched for is properly set when doing distcheck.
Comment 4 Johan Bilien 2010-02-01 22:53:50 UTC
that sounds a little broken to me, doesn't this mean you will get the gir file which matches the system of whoever built the tarball?
Comment 5 André Klapper 2015-02-07 16:46:53 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]