GNOME Bugzilla – Bug 608720
sabayon-2.29.5 Make Details pane less confusing with sorting
Last modified: 2010-02-05 02:58:55 UTC
http://mail.gnome.org/archives/sabayon-list/2010-January/msg00010.html After I upgraded from sabayon-2.29.2 to 2.29.5, the two items in the details pane "Mandatory GConf settings" and "Default GConf settings" became hidden in the middle of a long list of files when previously they were at the top of the list above any files. Action: Make non-files on top, above the files.
MainThread 2010/02/01 17:29:36.3744 (storage): Creating profile 'test' from '/etc/sabayon/profiles/test.zip' MainThread 2010/02/01 17:29:36.3745 (user-profile): Loading modules from /usr/lib64/python2.6/site-packages/sabayon/sources MainThread 2010/02/01 17:29:36.3749 (user-profile): Loading module: gconfsource MainThread 2010/02/01 17:29:36.3776 (user-profile): Loading module: mozillasource MainThread 2010/02/01 17:29:36.3956 (user-profile): Loading module: filessource MainThread 2010/02/01 17:29:36.3965 (user-profile): Loading module: paneldelegate <SNIP> MainThread 2010/02/01 17:29:36.4905 (admin-tool): source Files, path .evolution/calendar/local, description .evolution/calendar/local MainThread 2010/02/01 17:29:36.4906 (admin-tool): source Files, path .evolution/calendar/local/system, description .evolution/calendar/local/system MainThread 2010/02/01 17:29:36.4907 (admin-tool): source Files, path .evolution/calendar/config, description .evolution/calendar/config MainThread 2010/02/01 17:29:36.4908 (admin-tool): source GConf, path .gconf.xml.defaults, description Default GConf settings MainThread 2010/02/01 17:29:36.4909 (admin-tool): source GConf, path .gconf.xml.mandatory, description Mandatory GConf settings MainThread 2010/02/01 17:29:36.4910 (admin-tool): source Files, path .bash_logout, description .bash_logout MainThread 2010/02/01 17:29:36.4911 (admin-tool): source Files, path .bashrc, description .bashrc At first I thought userprofile.py os.listdir() order mattered, but this part of the code has not changed since 2005. Oddly enough, the order of "source GConf" appearing within "source Files" is not the same order of files and GConf appearing within the Details pane. This is pointing more toward the Glade3 -> GtkBuilder conversion that happened between 2.29.2 and 2.29.5 as the culprit. More digging...
http://git.gnome.org/browse/sabayon/commit/?id=a4177b02d5de278b41c26c1b891147668670f719 Committed intermediate implementation of sort. It works with the current code, but needs refactoring to get rid of hard-coding of Source names to work with arbitrary configuration sources. Working on this cleanup that should be functionally equivalent next.
http://git.gnome.org/browse/sabayon/commit/?id=070885b04ccf7bc42e3e4f0fa44744e2b92433e2 Remove hard coded names from Details pane sort function SORTPRIORITY must be set in each source constructor. Lower numbers appear before higher numbers in the Details pane view. Unless I made any mistakes or somebody wants to go in and clean it up further, I consider this particular bug to be done. Further UI improvements can be made but they should be specified in separate bugs.