After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608696 - Drawing order for tree lines
Drawing order for tree lines
Status: RESOLVED DUPLICATE of bug 491518
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
Depends on:
Blocks:
 
 
Reported: 2010-02-01 16:56 UTC by David Zeuthen (not reading bugmail)
Modified: 2010-03-14 10:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Current drawing order (77.34 KB, image/png)
2010-02-01 16:57 UTC, David Zeuthen (not reading bugmail) 		  Details
Desired drawing order (77.42 KB, image/png)
2010-02-01 16:57 UTC, David Zeuthen (not reading bugmail) 		  Details
Proposed patch (5.47 KB, patch)
2010-02-01 16:59 UTC, David Zeuthen (not reading bugmail) 		none Details | Review

Description David Zeuthen (not reading bugmail) 2010-02-01 16:56:48 UTC 
For some reason tree lines are drawn on top of cells instead of below. This looks weird (see screenshots).
Comment 1 David Zeuthen (not reading bugmail) 2010-02-01 16:57:14 UTC 
Created attachment 152736 [details]
Current drawing order
Comment 2 David Zeuthen (not reading bugmail) 2010-02-01 16:57:42 UTC 
Created attachment 152737 [details]
Desired drawing order
Comment 3 David Zeuthen (not reading bugmail) 2010-02-01 16:59:44 UTC 
Created attachment 152738 [details] [review]
Proposed patch
Comment 4 Hans van Hintum 2010-03-03 11:46:49 UTC 
(In reply to comment #3)
> Created an attachment (id=152738) [details] [review]
> Proposed patch

is this not a duplicate of 491518?

For that problem another patch is proposed. The advantage of that patch over this patch is, that I think the other patch really solve the cause of the problem (being that the treeview draws the wrong treeline) and not only covers the visual problem.

If you look at the result of your patch, than there is a difference between the horizontal lines for the expander of "CD/DVD drive" and "80 GB Solid-State Disk"; the first has "3 pixels' on the line and the last one "4 pixels". This is probably caused by the fact that these images have transparent pixels.
In this particular situation, the difference is not that big, but in other situations, the results may become visual "less attractive".
Comment 5 Kristian Rietveld 2010-03-14 10:33:08 UTC 
(In reply to comment #4)
> is this not a duplicate of 491518?

It is, marking it as such.

*** This bug has been marked as a duplicate of bug 491518 ***