GNOME Bugzilla – Bug 608553
Regression: Generating catch clauses
Last modified: 2010-02-04 19:56:37 UTC
The following commit causes an regression: commit 70481713241901c1dd592d5295bc1061a72ca59a Author: Jürg Billeter <j@bitron.ch> Date: Wed Jan 27 18:30:08 2010 +0100 Distinguish between unhandled and unexpected errors This fixes C warnings due to unexpected error handling. valac shows a critical warning: ** (valac:27502): CRITICAL **: vala_ccode_fragment_append: assertion `node != NULL' failed
+ Trace 220320
The generated C code contains errors: src/RecordingsStore.c: In function ‘dvb_recordings_store_restore_from_dir’: src/RecordingsStore.c:899: error: duplicate label ‘__catch45_g_error’ src/RecordingsStore.c:830: note: previous definition of ‘__catch45_g_error’ was here src/RecordingsStore.c:909: error: duplicate label ‘__finally45’ src/RecordingsStore.c:840: note: previous definition of ‘__finally45’ was here src/RecordingsStore.c:965: error: duplicate label ‘__catch45_g_error’ src/RecordingsStore.c:830: note: previous definition of ‘__catch45_g_error’ was here src/RecordingsStore.c:975: error: duplicate label ‘__finally45’ src/RecordingsStore.c:840: note: previous definition of ‘__finally45’ was here src/RecordingsStore.c:1048: error: duplicate label ‘__catch45_g_error’ src/RecordingsStore.c:830: note: previous definition of ‘__catch45_g_error’ was here src/RecordingsStore.c:1058: error: duplicate label ‘__finally45’ src/RecordingsStore.c:840: note: previous definition of ‘__finally45’ was here
Created attachment 152646 [details] Test case Here is a smaller test case with backtrace:
+ Trace 220321
commit 7df672793c8305535c3f159af77041d9d64b801a Author: Jürg Billeter <j@bitron.ch> Date: Thu Feb 4 20:55:16 2010 +0100 Do not check unexpected errors if there is a general catch clause Fixes bug 608553.