After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608446 - [playbin2] post an error message if no URI is set
[playbin2] post an error message if no URI is set
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-29 13:59 UTC by Tim-Philipp Müller
Modified: 2010-01-30 15:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playbin2: when no uri is set, post an error message (1.62 KB, patch)
2010-01-29 13:59 UTC, Tim-Philipp Müller 		committed Details | Review

Description Tim-Philipp Müller 2010-01-29 13:59:57 UTC 
Created attachment 152573 [details] [review]
playbin2: when no uri is set, post an error message

gst-launch-0.10 playbin2

should fail with a proper error message posted on the bus. Just returning FAILURE from the state change function is not enough.
Comment 1 Wim Taymans 2010-01-29 17:26:16 UTC 
sounds like a good thing to do.
Comment 2 Tim-Philipp Müller 2010-01-30 15:42:20 UTC 
commit 16601b09fe8704ba0f80465fe788a36d17caff91
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri Jan 29 13:56:05 2010 +0000

    playbin2: when no uri is set, post an error message
    
    When no uri is set, don't just return STATE_CHANGE_FAILURE from the
    state change function, but actually post an error message.