After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608409 - should die with session bus
should die with session bus
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
git master
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-29 04:59 UTC by William Jon McCann
Modified: 2012-06-04 22:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.91 KB, patch)
2010-01-29 05:33 UTC, William Jon McCann 		none Details | Review
main: exit gracefully when disconnected from the session bus (2.75 KB, patch)
2012-06-04 22:30 UTC, Ray Strode [halfline] 		committed Details | Review
main: fail if we can't get a connection to the session bus (1.95 KB, patch)
2012-06-04 22:30 UTC, Ray Strode [halfline] 		committed Details | Review

Description William Jon McCann 2010-01-29 04:59:14 UTC 
I'm sure we'll get into the age old question of who starts who but here's the bug:

1. Login to gnome-session
2. simulate a dbus crash by doing pkill -f dbus


What happens for me is the session goes into a loop trying to restart apps and reconnect to the session.  Trying to reconnect to the session bus is crazy.  gnome-session should exit in this case.
Comment 1 William Jon McCann 2010-01-29 05:33:51 UTC 
Created attachment 152547 [details] [review]
patch

There may also be some value in converting some of the g_criticals to g_errors.  Unless they interfere with the clean shutdown added in this patch.
Comment 2 Vincent Untz 2010-01-29 11:00:13 UTC 
Josselin: any comment on this?
Comment 3 Josselin Mouette 2010-01-29 11:06:57 UTC 
I agree on principle that the only sane thing to do in this case is to exit. The only reconnection that should happen is when the system bus restarts, for the session bus this is pure madness.

And indeed, we’d need to test the patch in both cases (dbus-launch gnome-session, and gnome-session starting dbus-daemon itself).
Comment 4 Ray Strode [halfline] 2012-06-04 22:30:32 UTC 
Created attachment 215592 [details] [review]
main: exit gracefully when disconnected from the session bus

This fixes a problem where all hell breaks loose if we
lose the bus.
Comment 5 Ray Strode [halfline] 2012-06-04 22:30:35 UTC 
Created attachment 215593 [details] [review]
main: fail if we can't get a connection to the session bus

Right now we try to keep on chugging, but that's in vain.

It's better to just fail whale.
Comment 6 Ray Strode [halfline] 2012-06-04 22:39:03 UTC 
Attachment 215592 [details] pushed as 34c3805 - main: exit gracefully when disconnected from the session bus
Attachment 215593 [details] pushed as fea0daf - main: fail if we can't get a connection to the session bus