After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608341 - single block part on top of the game
single block part on top of the game
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: quadrapassel
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
: 619510 629460 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-01-28 14:27 UTC by Pedro Villavicencio
Modified: 2012-01-31 23:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Patch to fix the bug (1.04 KB, patch)
2010-07-29 22:43 UTC, Craig Duncan
committed Details | Review

Description Pedro Villavicencio 2010-01-28 14:27:04 UTC
this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/gnome-games/+bug/487991

"when you fill with blocks any column to top, after completing and explosion of any line, up-line is remain on his top place (Gnometris-screenshot1)."

screenshot:

http://launchpadlibrarian.net/36048567/Gnometris-screenshot1.png

"I can confirm this bug. I noticed it during a regular game and then quickly reproduced it in a second game. I will attach a `before` and `after` screenshot."

http://launchpadlibrarian.net/38488696/Screenshot-Gnometris-Before.png

http://launchpadlibrarian.net/38488796/Screenshot-Gnometris-After.png
Comment 1 Craig Duncan 2010-07-29 22:43:31 UTC
Created attachment 166807 [details] [review]
Patch to fix the bug

I think I've found the cause of this. It appears to be a problem with a loop using an incorrect range.

This means it attempts to move a row that doesn't exist, and doesn't attempt to move the top row.

The following patch fixed the problem for me
Comment 2 Thomas Andersen 2010-08-09 19:22:39 UTC
Comment on attachment 166807 [details] [review]
Patch to fix the bug

Nice work :)

Committed to master:
http://git.gnome.org/browse/gnome-games/commit/?id=fed9a37e62e7f69f8e410cb7f78126ee84c7ee22
Comment 3 Jason Clinton 2010-09-13 21:36:52 UTC
*** Bug 629460 has been marked as a duplicate of this bug. ***
Comment 4 Thomas Andersen 2010-09-13 21:36:53 UTC
*** Bug 619510 has been marked as a duplicate of this bug. ***
Comment 5 Robert Ancell 2012-01-31 23:21:57 UTC
This bug is being reassigned to the "quadrapassel" component so we can close the gnometris bugzilla component.  Apologies for the mass email!