After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608296 - Maximized window keeps focus on alt-tab
Maximized window keeps focus on alt-tab
Status: RESOLVED DUPLICATE of bug 599181
Product: metacity
Classification: Other
Component: Focus
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Thomas Thurman
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2010-01-27 23:44 UTC by cosinusoidaly
Modified: 2010-06-09 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description cosinusoidaly 2010-01-27 23:44:19 UTC
To reproduce bug:

* open an xterm
* open a gedit window
* Double click the gedit window in order to maximize it
* ALt-Tab to the xterm
* Attempt to grab the xterm by its title bar

Doing so grabs the gedit window rather than the xterm.

I dug around a bit with git bisect. This diff seems to have caused the bug:

$ git diff 9abdc6c0fab7b66380f1f1eb555c89cbc1131e1d 38faa8fe109071dcb9c49fdbc13774d13f4

diff --git a/ChangeLog b/ChangeLog
index 4aaea57..507f42e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-12-19  Thomas Thurman  <tthurman@gnome.org>
+
+       * src/ui/frames.c: when the user double-clicks the title bar,
+         end the grab op.  Closes #401028.
+
 2008-12-16  Thomas Thurman  <tthurman@gnome.org>
 
         * configure.in: Post-release bump to 2.25.89.
diff --git a/src/ui/frames.c b/src/ui/frames.c
index 093af92..700e747 100644
--- a/src/ui/frames.c
+++ b/src/ui/frames.c
@@ -1388,6 +1388,7 @@ meta_frames_button_press_event (GtkWidget      *widget,
       event->button == 1 &&
       event->type == GDK_2BUTTON_PRESS)
     {
+      meta_core_end_grab_op (gdk_display, event->time);
       return meta_frame_double_click_event (frame, event);
     }
Comment 1 Hernando Torque 2010-03-26 09:26:23 UTC
I can confirm that reverting that commit fixes dragging the wrong window
and making the maximized window show the button pressed state.

Bug 608296 seems to be a duplicate.

I could not reproduce bug 600227 and bug 608139 but they might be connected.

This is a bad usability bug, please consider raising its priority.
Comment 2 Hernando Torque 2010-03-26 09:29:43 UTC
Sorry, meant bug 608144 being a dupe. :)
Comment 3 Hernando Torque 2010-04-11 09:50:09 UTC
I can reproduce bugs 600227 and 608139 too, just failed to follow the mentioned steps (instead it happened to me during normal desktop use). Closing the wrong window sounds pretty severe to me.

Can you please mark bugs 600227, 608139, and 608144 as dupes and raise the version to 2.30.x (I'm using an up-to-date Ubuntu 10.04 with Metacity version 2.30.1-0ubuntu1)?
Comment 4 Owen Taylor 2010-06-09 16:24:56 UTC
To keep sanity, I'm marking everything as duplicates on the first reported bug - bug 599181

I'll add a comment there mentioning the bisecting to the commit above.

*** This bug has been marked as a duplicate of bug 599181 ***